Bug 247628 - [changeset] Having 2 edit actions in context menu is confusing
Summary: [changeset] Having 2 edit actions in context menu is confusing
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords: polish
: 205409 (view as bug list)
Depends on: 269830
Blocks:
  Show dependency tree
 
Reported: 2008-09-17 07:05 EDT by Philipe Mulet CLA
Modified: 2009-08-11 05:57 EDT (History)
5 users (show)

See Also:

Attachments
Context menu rearranged (1) (72.21 KB, image/jpeg)
2009-03-24 12:43 EDT, Szymon Brandys CLA 		no flags Details
Context menu rearranged (2) (58.66 KB, image/jpeg)
2009-03-24 12:43 EDT, Szymon Brandys CLA 		no flags Details
Fix v01 (28.76 KB, patch)
2009-03-25 12:57 EDT, Szymon Brandys CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2008-09-17 07:05:36 EDT 
Build 3.5M2

ChangeSet support is a nice addition. In term of polish though, there are 2 entries available in the context menu for editing it.

Hence, it is quite confusing for renaming an existing changeset (the top action is actually not doing what you'd expect).
Comment 1 Szymon Brandys CLA 2009-03-24 12:43:10 EDT 
Created attachment 129713 [details]
Context menu rearranged (1)
Comment 2 Szymon Brandys CLA 2009-03-24 12:43:33 EDT 
Created attachment 129714 [details]
Context menu rearranged (2)
Comment 3 Szymon Brandys CLA 2009-03-24 12:44:27 EDT 
Screen shots includes changes for bug 269830.
Comment 4 Szymon Brandys CLA 2009-03-24 12:54:13 EDT 
Let me know what you think about suggested changes. Please notice that only available items are visible. So when resources/changes are selected, only "Reassign Changes To" is visible.

I changed wording since "Add To" is not clear. I think that "Reassign..." sounds better. The same for "Sort..." item.
Comment 5 Tomasz Zarna CLA 2009-03-25 07:16:38 EDT 
If possible I would add the "Sort..." item to the View's drop down menu. It would look the same way as in the Repo view.
Comment 6 Dani Megert CLA 2009-03-25 07:56:36 EDT 
Looks good, especially the edit actions being top-level again.

>I changed wording since "Add To" is not clear. I think that "Reassign..."
>sounds better. 
I assume this is only done for elements that are already assigned and for non-assigned ones I still get "Add To", right?

I agree with Tomasz on the sort item.
Comment 7 Szymon Brandys CLA 2009-03-25 09:31:04 EDT 
(In reply to comment #6)
> I assume this is only done for elements that are already assigned and for
> non-assigned ones I still get "Add To", right?

I would like to find one expression for both cases. I thought that "Reassign Changes To" would work for both, those already assigned and those that are unassigned. Maybe just "Assign To" is fine?
Comment 8 Dani Megert CLA 2009-03-25 09:49:50 EDT 
Can't you update the label based on whether it's in a working set or not? I think it's better to use "reassign" if the element is already in a working set.
Comment 9 Szymon Brandys CLA 2009-03-25 12:57:13 EDT 
Created attachment 129861 [details]
Fix v01
Comment 10 Szymon Brandys CLA 2009-03-25 12:58:32 EDT 
(In reply to comment #8)
> Can't you update the label based on whether it's in a working set or not? I
> think it's better to use "reassign" if the element is already in a working set.

With the patch we will have "Assign To" for unassigned changes and "Reassign To" for those within a change set.
Comment 11 Szymon Brandys CLA 2009-03-26 06:09:20 EDT 
Released to HEAD. New bugs raised: bug 270101 and bug 270102.
Comment 12 Tomasz Zarna CLA 2009-08-11 05:57:56 EDT 
*** Bug 205409 has been marked as a duplicate of this bug. ***