Bug 247408 - [Net] Deprecate getProxyDataForHost(String) in the IProxyService API
Summary: [Net] Deprecate getProxyDataForHost(String) in the IProxyService API
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-16 04:03 EDT by Pawel Pogorzelski CLA
Modified: 2009-06-02 06:55 EDT (History)
1 user (show)

See Also:

Attachments
Patch_v01 (6.60 KB, patch)
2008-11-21 10:03 EST, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v02 (6.73 KB, patch)
2008-11-21 10:35 EST, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pogorzelski CLA 2008-09-16 04:03:58 EDT 
Build ID: I20080903-1200

Methods getProxyDataForHost(String) and getProxyDataForHost(String, String) are error prone. First of all it might be unclear to clients how the methods operate. Also, String class is not the best choice to represent hosts since it does not enforce any constraints on arguments passed.

The methods should be deprecated and a new method getProxyDataForHost(URL host) should be introduced. The new method should return proxy settings for a given protocol type.
Comment 1 Pawel Pogorzelski CLA 2008-11-21 10:03:48 EST 
Created attachment 118476 [details]
Patch_v01

Szymon, what do you think about the patch?
Comment 2 Pawel Pogorzelski CLA 2008-11-21 10:35:41 EST 
Created attachment 118481 [details]
Patch_v02
Comment 3 Szymon Brandys CLA 2008-11-21 10:42:47 EST 
Looks good. Thanks Pawel.
Comment 4 Tomasz Zarna CLA 2008-11-21 11:01:18 EST 
Released to HEAD.