Bug 247 - Compare with Stream Contents does not prompt for save changes. (1GJW3AI)
Summary: Compare with Stream Contents does not prompt for save changes. (1GJW3AI)
Status: RESOLVED DUPLICATE of bug 85
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: James Moody CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 2854
Blocks:
  Show dependency tree
 
Reported: 2001-10-10 21:38 EDT by Tod Creasey CLA
Modified: 2002-03-06 22:59 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2001-10-10 21:38:52 EDT
If you copy over text using the Compare Browser when doing a Compare with 
Stream Contents
you do not get prompted to save changed when you close the browser.

STEPS
	1) Create a file foo.txt with content.
	2) Release it to the stream
	3) Edit foo.txt
	4) Save and compare with stream
	5) Copy over stream contents
	6) Close the compare browser - no prompt for changes.


NOTES:

JEM (9/12/2001 11:38:47 AM)
	Possibly related to
		1GFMRMH: ITPVCM:ALL - Project compare: edited files aren't 
marked

JEM (9/12/2001 2:36:54 PM)
	Impossible to do properly given the current compare framework. If we 
get rid of our implementation
	of VCMCompareEditorInput.isSaveNeeded(), then the when we close the 
editor we get the following behaviour:

	1. Editor says changes exist, do you want to save? (y/n/cancel)
	2. User says "yes"
	3. CompareEditor.doSave() first sends setInput(null) to each pane, then 
sends save() to the CompareEditorInput.
	BUT
	setInput(null) sent to each pane may cause additional prompting 
(changes exist, do you want to save? (y/n/cancel))
	because, in ContentMergeViewer.inputChanged(), if fConfirmSave is true, 
the pane prompts for saving changes.

	We have no control over fConfirmSave, as it is a global setting. 
(Anyway, even if we did, we wouldn't turn it off
	because it is needed for the case that the user clicks on a different 
item in the tree).

	Why does this not happen in the normal (non-VCM) compare case? Because 
we enable the save actions in
	our editors, and in ContentMergeViewer.inputChanged(), the prompting 
only happens if the save actions are
	enabled.

	This code path needs to be fixed before we can prompt in this way.

JEM (9/12/2001 3:31:02 PM)
	Waiting on Compare PR:

	1GJYGAX: ITPJUI:WIN2000 - Compare: Save code path problematic
Comment 1 DJ Houghton CLA 2001-10-23 23:48:44 EDT
PRODUCT VERSION: build 135


Comment 2 Kevin McGuire CLA 2002-03-06 22:59:50 EST

*** This bug has been marked as a duplicate of 85 ***