Bug 246833 - [Trim] Toggle StatusLine
Summary: [Trim] Toggle StatusLine
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-09-10 04:45 EDT by Laurent Muller CLA
Modified: 2019-09-06 15:31 EDT (History)
0 users

See Also:


Attachments
First implementation (3.18 KB, text/plain)
2008-09-10 04:47 EDT, Laurent Muller CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Muller CLA 2008-09-10 04:45:04 EDT
It will be great if the Eclispe provides a handler to show or hide the status line like do the ToggleCoolbarHandler for the toolbar. I have already create a java class for this but with some restrictions.
Comment 1 Laurent Muller CLA 2008-09-10 04:47:04 EDT
Created attachment 112175 [details]
First implementation
Comment 2 Eric Moffatt CLA 2008-09-12 13:54:18 EDT
Thanks Laurent...patches are always a welcome sight...;-)
Comment 3 Boris Bokowski CLA 2009-05-06 16:50:35 EDT
Removing 3.5 target milestone. We are in the end-game now. Please have a look and decide if this should be targeted at 3.6.
Comment 4 Eric Moffatt CLA 2009-05-07 10:22:00 EDT
Laurent, when you say 'status line' do you expect the result to be that -everything- in the bottom trim is hidden or just the StatusLine itself (and not the ProgressBar...)?
Comment 5 Laurent Muller CLA 2009-05-07 10:37:23 EDT
What I want, if possible, it's that EVERYTHING in the bottom trim is hidden like in the attached code.
Comment 6 Eric Moffatt CLA 2009-11-25 10:09:05 EST
Laurent, I've taken a look at the patch and like it, simple understandable code always makes folks life easier...

Here's a few suggestions on areas you may want to take a look at:

Persistence: If someone executes this command then it should likely stay in that state across re-launches of the eclipse sessions (see bug 158642).

What happens if new trim gets added to the trim after 'hiding'? For example you can run the toggle command and then show the 'Heap Status' (Window -> Preferences... -> General has a checkbox). The current implementation will now have the Heap Status widget all by itself in the trim.

BTW, what were the restrictions you mentioned in your description?
Comment 7 Laurent Muller CLA 2009-11-25 12:03:42 EST
Ideally, when trim is added, ITrimManager must be send messages to listeners to said that something happened.

The restrictions I mentioned is about the dependency of the WorkbenchWindow, ITrimManager and the IWindowTrim objects. All this classes are "internal" and I must add the @SuppressWarnings("restriction") attribute.
Comment 8 Eric Moffatt CLA 2009-11-25 14:29:25 EST
Laurent, I'll gladly review any patches you want to put here but I'm going to remove the 3.6 milestone (it's reserved for things that *have to* get into 3.6).
Comment 9 Eclipse Webmaster CLA 2019-09-06 15:31:08 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.