Description Jacek Kolodziejczyk 2008-09-02 05:47:17 EDT

Build ID: I20080617-2000

Steps To Reproduce:
I have a an empty row at the end of a ColumnViewer to insert new elements, like there are in many data oriented applications. Editors are activated on ColumnViewerEditorActivationEvent.TRAVERSAL. What I do when a cell was edited in the insert item, is to replace the insert item's data (dummy element) with the newly created domain element (having the entered cell value) using StructuredViewer.associate, update the labels and create a new insert item.
The pseudo code:
	if (currentElement == DUMMY) {
		DomainObject element = createDomainObject();
		element.setValue(editor.getValue();
		viewer.associate(element, currentItem);
		viewer.update(element, null);
		viewer.add(DUMMY);
	}

The problem is when I traverse to the next cell by TAB, it goes to the new insert item below instead to the one just created in the current row. 

More information:
This is because the element reference changes between the current editor is closed and the new one is opened. I think this would not happen if ViewerCell would not cache the element reference, but always take it from the row.getElement() (which takes it from the Item.getData())

So I suggest changing ViewerCell.getElement() from this:

   public Object getElement() {
		if (element != null) {
			return element;
		}

		if (row != null) {
			return row.getElement();
		}

		return null;
	}

to this at least: 

   public Object getElement() {
		if (row != null) {
			return row.getElement();
		}
		
		if (element != null) {
			return element;
		}

		return null;
	}

if the element member is needed at all when the row is empty (I'm not aware of such a case possibility and the sense of a cell with an empty row).