Bug 245808 - CVS commit choose previous comment combobox popup too large
Summary: CVS commit choose previous comment combobox popup too large
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.4   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-08-31 23:34 EDT by Vincent Petry CLA
Modified: 2019-09-06 15:30 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Petry CLA 2008-08-31 23:34:43 EDT
Build ID: I20080617-2000

Steps To Reproduce:
1. Commit a modified file to CVS by selecting Team->Commit.
2. In the dialog box, enter a very long comment without newlines.
3. Click ok.
4. Select another modified file and select Team->Commit.
5. Click on "Choose a previously entered comment"

Expected result:
The combobox popup shows a shortened version of the previous comments.
The width is smaller than the screen's width.

Actual result:
The combobox popup's width exceeds the width of the screen. (and when using compiz-fusion, the popup is blank, maybe because of its too big width)

More information:
I think it would be more convenient to replace the combobox with a dialog box containing the previous comments. This way it would be possible to display more than one line from each comment, and restrict the dialog's size.

Else, it would also be nice to have a feature that clears this combobox' entries. There is a feature "Configure comment templates" but it seems to be something different because I can't see my previous comments in that list.
Comment 1 Tomasz Zarna CLA 2008-09-01 04:43:28 EDT
Please take a look at bug 208869 as well as bug 39302 and bug 39302. It seems to be more like a SWT bug, but if you're willing to send us a patch doing the things mentioned above we could fix it on our side. Otherwise, I think I will have to close it marking it as a dupe.
Comment 2 Vincent Petry CLA 2008-09-01 04:57:00 EDT
I think that using a combobox to display text that can be long or multiline is anyway not appropriate. In this case, this bug might be considered as an enhancement request.
Comment 3 Tomasz Zarna CLA 2008-09-01 07:15:38 EDT
(In reply to comment #0)
> I think it would be more convenient to replace the combobox with a dialog box
> containing the previous comments. This way it would be possible to display more
> than one line from each comment, and restrict the dialog's size.

What's worrying me about this solution is that we will end up with 2 dialogs opened at the same time which is not very common. Patches and other suggestions are welcome.
Comment 4 Vincent Petry CLA 2008-09-01 21:47:00 EDT
Yes, but there is already a feature "Configure comment templates" on that same dialog box which also opens a new dialog box containing preference pages.
I agree that having more than one open dialog box is not very convenient, there is probably a more elegant way to achieve it.
Comment 5 Eclipse Webmaster CLA 2019-09-06 15:30:21 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.