Bug 24578 - Can't add variable to tool arguments
Summary: Can't add variable to tool arguments
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: Other All
: P3 normal (vote)
Target Milestone: 2.1 M3   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks:
 
Reported: 2002-10-09 10:11 EDT by Jared Burns CLA
Modified: 2002-11-04 21:36 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2002-10-09 10:11:17 EDT 
1. Go to the "Options" page of the external tool property page.
2. Click on "Variable" to add a variable to the arguments area.
3. Select a variable and click OK.
4. The variable does not appear in the arguments area and an exception 
occurs:

java.lang.NullPointerException
	at 
org.eclipse.ui.externaltools.group.ExternalToolOptionGroup.handleButtonPressed(ExternalToolOptionGroup.java:206)
	at 
org.eclipse.ui.externaltools.group.ExternalToolOptionGroup.access$0(ExternalToolOptionGroup.java:201)
	at 
org.eclipse.ui.externaltools.group.ExternalToolOptionGroup$2.widgetSelected(ExternalToolOptionGroup.java:189)
	at 
org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:87)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:77)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:872)
	at 
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1733)
	at 
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1551)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:562)
	at org.eclipse.jface.window.Window.open(Window.java:542)
	at 
org.eclipse.ui.dialogs.PropertyDialogAction.run(PropertyDialogAction.java:159)
	at 
org.eclipse.ui.externaltools.internal.view.EditExternalToolPropertiesAction.run(EditExternalToolPropertiesAction.java:54)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:749)
	at 
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:407)
	at 
org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent(ActionContributionItem.java:361)
	at 
org.eclipse.jface.action.ActionContributionItem.access$0(ActionContributionItem.java:352)
	at 
org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java:47)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:77)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:872)
	at 
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1733)
	at 
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1551)
	at 
org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1272)
	at org.eclipse.ui.internal.Workbench.run(Workbench.java:1255)
	at 
org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:775)
	at org.eclipse.core.boot.BootLoader.run(BootLoader.java:462)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:247)
	at org.eclipse.core.launcher.Main.run(Main.java:703)
	at org.eclipse.core.launcher.Main.main(Main.java:539)
Comment 1 Jared Burns CLA 2002-10-10 09:51:42 EDT 
Fixed. When adding a resource_loc variable, we weren't properly retrieving the 
user's selection. See ExternalToolOptionGroup and ResourceComponent.
Comment 2 Jared Burns CLA 2002-10-10 09:51:52 EDT 
Please verify.
Comment 3 Darin Swanson CLA 2002-11-04 21:36:52 EST 
Verified.