Bug 245424 - fixpath routine cannot handle directory with two periods
Summary: fixpath routine cannot handle directory with two periods
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Leslie Davis CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-08-27 14:13 EDT by Neil Hauge CLA
Modified: 2022-06-09 10:10 EDT (History)
2 users (show)

See Also:

Attachments
Reworked cmd files that work for both Windows XP and Vista (2.76 KB, patch)
2009-01-15 11:18 EST, Pascal Filion CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Hauge CLA 2008-08-27 14:13:21 EDT 
NoClassDefFoundError when starting the Workbench on 8-27 build.
Comment 1 Neil Hauge CLA 2008-08-27 14:14:20 EDT 
This should be addressed in 1.0.1M2/RC.
Comment 2 Neil Hauge CLA 2008-08-27 17:54:41 EDT 
The problem was that one of the directories in my EclipseLink path had 2 periods in the directory name.  Apparently this causes the fixpath routine to insert garbage into paths, including the classpath entries.  This bug has likely existed for some time.

This is a pretty serious bug, in that it would prevent any utility from running that meets these conditions, but it does have a workaround:  Change the offending directory name.  This may not be possible is some cases, so I think this should be fixed for 1.0.1 if possible.
Comment 3 Neil Hauge CLA 2008-10-17 14:24:48 EDT 
Here is the fixpath function in question:


:fixpath
if not %1.==. (
  for /f "tokens=1* delims=;" %%a in (%1) do (
    call :shortfilename "%%a" & call :fixpath "%%b"
  )
)
goto :EOF

:shortfilename
for %%i in (%1) do set _FIXPATH=%_FIXPATH%;%%~fsi
goto :EOF
Comment 4 Neil Hauge CLA 2008-10-21 18:53:45 EDT 
We haven't been able to nail down a fix for this yet that works on everyone's test environment.  As a result of that, and not wanting to end up with something that might be worse, I think we may need to defer this for now and get a change into an earlier build for a maintenance or other release.  Broader testing by the community would be good with any changes in this area.

I'll assign this to me for now.
Comment 5 Neil Hauge CLA 2009-01-12 16:03:16 EST 
We have a candidate fix for this issue (to be attached shortly), but it has not been sufficiently tested at this point, nor has it been tested by users.

Given that this bug has not been reported by a user, and that there is a workaround, I am downgrading the severity to normal.  Also, given the risk associated with the fix, it would be better to fix this in an early milestone for a release, and not at the end.  Due to these factors I am re-targeting to 2.0.
Comment 6 Pascal Filion CLA 2009-01-15 11:18:43 EST 
Created attachment 122689 [details]
Reworked cmd files that work for both Windows XP and Vista
Comment 7 Neil Hauge CLA 2009-11-30 11:59:18 EST 
Moving to 2.1 release.
Comment 8 Eclipse Webmaster CLA 2022-06-09 10:10:38 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink