Bug 245270 - [api][context] support monitoring of things other than workbench parts
Summary: [api][context] support monitoring of things other than workbench parts
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1   Edit
Assignee: Shawn Minto CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-08-26 11:47 EDT by Shawn Minto CLA
Modified: 2009-01-15 16:53 EST (History)
1 user (show)

See Also:

Attachments
patch (5.55 KB, patch)
2008-08-26 11:55 EDT, Shawn Minto CLA 		steffen.pingel: iplog+
Details | Diff
mylyn/context/zip (2.49 KB, application/octet-stream)
2008-08-26 11:55 EDT, Shawn Minto CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2008-08-26 11:47:55 EDT 
Currently, Mylyn requires that an AbstractUserInteractionMonitor have a WorkbenchPart to pass to the super method for an id.  Currently, if there is no workbench part (i.e. dialog boxes are being monitored), the code in AbstractUserInteractionMonitor must be copied so that it can pass an id, or the developer must "fake" a WorkbenchPart for proper monitoring. Since AbstractUserInteractionMonitor doesn't use the WorkbenchPart for anything other than the WorkbenchSite's id, it would be nice to have a convenience method that would take a String id for these other cases so that this code can be re-used and not copied.
Comment 1 Shawn Minto CLA 2008-08-26 11:55:15 EDT 
Created attachment 110953 [details]
patch

Attached is a patch that creates 3 new methods (handle*) that take a String id instead of a workbench part.  To ensure that this code is re-usable, I have made the existing methods call these ones instead.  This means that there is only 1 place to maintain the code.  Since this is an API change, I understand that this patch cannot be applied until 3.1.
Comment 2 Shawn Minto CLA 2008-08-26 11:55:17 EDT 
Created attachment 110954 [details]
mylyn/context/zip
Comment 3 Mik Kersten CLA 2008-09-04 23:55:28 EDT 
Shawn: Bug me again on this bug if I don`t get to this in a week or two after the Mylyn 3.0.2 release (Septembe 17th).
Comment 4 Steffen Pingel CLA 2009-01-15 16:53:10 EST 
Patch applied. Thanks Shawn!