Community
Participate
Working Groups
I20080821-1005 To solve bug 39364, WorkingSetConfigurationBlock should support a mode for selecting working sets as scope of an operation. It should allow to choose the window working set and it should allow to modify existing and add new working sets. The required functionality has been listed in bug 39364 comment 8: > Hm, it's not that easy. The WorkingSetConfigurationBlock API ... > 1. does not offer a way to present all available working set types => bug 245106 > 2. always adds a check box (e.g. for "Add project to working sets"), which > must not show up in the search dialog > 3. does not list the workbench window working set and does not allow the user > to edit working sets => This could be implemented with a new constructor, e.g. WorkingSetConfigurationBlock(String[] workingSetIds, IDialogSettings settings, String comboLabel, String selectLabel), which: - suppresses the "Add project to working sets" checkbox - creates a WorkingSetSelectionDialog instead of a SimpleWorkingSetSelectionDialog
Hmm, I realized that we need a bit more than this to resolve bug 39364: In the search dialog, we should not have label in front of the combo (the scope selection radio serves as label there). We also need some notification when the working set has been changed (either via combo or via the button), because we have to select the "Working Set:" radio then. Maybe let WorkingSetConfigurationBlock implement ISelectionProvider. I'll look into this.
Hitesh, could you please assist Markus with this?
Created attachment 118877 [details] work in progress I've already started with this, but I had to stop because the fix became bigger than I expected. If you want, you can use my work in progress. I won't have time to do this for M4.
Created attachment 119367 [details] Something like this? We could separate out the combo box and the button into another block and use it the configuration block and the search dialog. Something like this? Your thoughts ?
Removing 3.5 target milestone. We are in the end-game now. Please have a look and decide if this should be targeted at 3.6.
Given we already have some patches here, I suggest to target this for 3.6.
(In reply to comment #6) > Given we already have some patches here, I suggest to target this for 3.6. > Dani, this will need a closer look. On reconsideration, I am not sure if either of the patches do anything significantly meaningful. Patch 1 : The 'scope mode', unfortunately, hardly belongs to the context of workingset selection .Try to think of the WorkingSetConfigurationBlock in general, not just from a search dialogs perspective. Patch 2 : Tries to address the need by extracting a subset UI. Seems OK initially but , but the WorkingSetComboBlock widget is not very meaningful, although very useful. Any thoughts?
>On reconsideration, I am not sure if either of the patches do anything >significantly meaningful. I didn't look at the patches. I only wanted to make sure the started work is not lost that's why I suggested to target it to 3.6. Definitely not something we should spend any cycles at this point.
Yep, 3.6 it is...
Removed from 3.6. Owners can re-assess. PW
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant please remove the stalebug whiteboard tag.
