Bug 24525 - Active targets not shown in ant tool property page
Summary: Active targets not shown in ant tool property page
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: Other All
: P2 normal (vote)
Target Milestone: 2.1 M3   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks:
 
Reported: 2002-10-08 13:54 EDT by Jared Burns CLA
Modified: 2002-11-04 21:34 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2002-10-08 13:54:47 EDT 
1. Bring up the Targets property page for an ant external tool (by right 
clicking in the external tools view).
2. Deselect the "Run default target" button and move some targets into the 
active targets list.
3. Hit OK to dismiss the property page.
4. Bring up the page again. The active targets list is empty.
Comment 1 Jared Burns CLA 2002-10-08 14:44:27 EDT 
Fixed in AntTargetsGroup and AntTargetsGroupPropertyPage. For some unknown 
reason, we were calling AntTargetsGroup.setLocation(...) from the property 
page instead of just setting it from within the group during initialization. 
Calling setLocation(...) has the side effect of calling 
updateAvailableTargets(), which was clearing the active targets which had 
already been calculated.

I moved the location setting call into the target group initialization code 
*before* we restore values from the tool. Also, I renamed 
updateAvailableTargets() to resetAvailableTargets() to better reflect the 
nature of that code.
Comment 2 Jared Burns CLA 2002-10-08 14:44:38 EDT 
Please verify.
Comment 3 Darin Swanson CLA 2002-11-04 21:34:12 EST 
Verified.