Bug 244736 - Too much whitespace in wizards
Summary: Too much whitespace in wizards
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: IDE4EDU (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2008-08-20 15:08 EDT by Wayne Beaton CLA
Modified: 2014-01-09 15:39 EST (History)
0 users

See Also:


Attachments
Patch that eliminates quite a lot of duplicate code (57.10 KB, patch)
2009-07-21 11:37 EDT, Wayne Beaton CLA
no flags Details | Diff
mylyn/context/zip (11.61 KB, application/octet-stream)
2009-07-21 11:37 EDT, Wayne Beaton CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Beaton CLA 2008-08-20 15:08:51 EDT
Wizards, especially the JavaLiteProjectWizard, open with too much blank space. A cursory review shows that the implementation just hides all the various groups that make up the original wizard. I assume that these hidden groups continue to occupy space.

This may be an opportunity to just build our own simplified wizards since we really only need to capture a name.
Comment 1 Wayne Beaton CLA 2009-04-03 13:09:38 EDT
We have an opportunity here to "do things right". I think that our best track here is to build separate UI and model components (the class that JavaLiteProjectWizard wizard is based on merges UI and model into one). That is, we should create a separate and completely non-UI "wizard" that--given sufficient configuration--can do the project creation for us. Our "UI" classes can then simply do what they do best: render a UI that drives the wizard. Using the word "wizard" in this context will likely be confusing, so we'll need to find a different word.

Our first implementation should provide only what we need. Ultimately, though, it's probably something that we can evolve to the point that it's a worthy contribution to the JDT project.
Comment 2 Wayne Beaton CLA 2009-06-23 14:38:40 EDT
I'd like to see this done soon. I have exchanged emails with several people about this bug, but do not see any of their names on the CC list. If somebody wants to do this bug, please indicate your interest here. I intend to look at this in the second week of July if nobody else has stepped up.
Comment 3 Wayne Beaton CLA 2009-07-21 10:18:32 EDT
As a first cut at resolving this bug, I am removing the unused sections of code.
Comment 4 Wayne Beaton CLA 2009-07-21 11:28:14 EDT
I believe that I've been able to eliminate the the NewJavaLiteProjectWizardPageTwo class and much of the NewJavaLiteProjectWizardPageOne class. This significantly reduces the amount of duplicate code and use of non-API. Will attach as patch for verification by others.
Comment 5 Wayne Beaton CLA 2009-07-21 11:37:46 EDT
Created attachment 142147 [details]
Patch that eliminates quite a lot of duplicate code

This patch removes NewJavaLiteProjectWizardPageTwo and significantly reduces the amount of code duplication in NewJavaLiteProjectWizardPageOne. Please verify that it functions as required.
Comment 6 Wayne Beaton CLA 2009-07-21 11:37:50 EDT
Created attachment 142148 [details]
mylyn/context/zip
Comment 7 Wayne Beaton CLA 2009-09-04 11:50:01 EDT
Marking bug as helpwanted; need somebody to verify that the patch is valid. Improvements welcome.
Comment 8 Wayne Beaton CLA 2009-09-08 14:15:27 EDT
Patch committed in HEAD.