Bug 244579 - [api] move task editor extension out of the sandbox
Summary: [api] move task editor extension out of the sandbox
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 3.1   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy, plan
Depends on:
Blocks: 244650 245187
  Show dependency tree
 
Reported: 2008-08-19 13:18 EDT by David Green CLA
Modified: 2008-10-17 14:18 EDT (History)
1 user (show)

See Also:

Attachments
first crack at moving extension out of the sanbox (not complete) (46.02 KB, patch)
2008-08-25 20:22 EDT, David Green CLA 		no flags Details | Diff
mylyn/context/zip (9.62 KB, application/octet-stream)
2008-08-25 20:22 EDT, David Green CLA 		no flags Details
reimplemented against head (90.02 KB, patch)
2008-10-06 11:40 EDT, David Green CLA 		no flags Details | Diff
mylyn/context/zip (8.37 KB, application/octet-stream)
2008-10-06 11:40 EDT, David Green CLA 		no flags Details
patch (107.39 KB, patch)
2008-10-16 23:21 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (20.84 KB, application/octet-stream)
2008-10-16 23:22 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Green CLA 2008-08-19 13:18:50 EDT 
the task editor extension is currently in the sandbox.  Moving this into Mylyn proper is a 3.1 release goal
Comment 1 David Green CLA 2008-08-25 20:22:49 EDT 
Created attachment 110874 [details]
first crack at moving extension out of the sanbox (not complete)
Comment 2 David Green CLA 2008-08-25 20:22:51 EDT 
Created attachment 110875 [details]
mylyn/context/zip
Comment 3 David Green CLA 2008-10-06 11:40:30 EDT 
Created attachment 114322 [details]
reimplemented against head

reimplemented in the simplest form possible.
Steffen, this one's ready for you!
Comment 4 David Green CLA 2008-10-06 11:40:36 EDT 
Created attachment 114323 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2008-10-06 17:42:29 EDT 
Thanks for your help David. Huge refactoring patches like this are difficult to review. It's usually easier if refactorings are done by the committer who is responsible for the component that is being changed. I would also like to review the code and API while moving it from the sandbox so I'll take this bug for now.
Comment 6 David Green CLA 2008-10-06 17:45:42 EDT 
(In reply to comment #5)
> Thanks for your help David. Huge refactoring patches like this are difficult to
> review. 

What I've found works well is to apply the patch, then compare the source tree against the latest revision in the repository.  The Eclipse compare editor is great at showing differences across multiple files.

> I would also like to review
> the code and API while moving it from the sandbox so I'll take this bug for now.

Ok, great.  I look forward to seeing this one completed.
Comment 7 Steffen Pingel CLA 2008-10-16 23:20:59 EDT 
I have moved the extension point and merged the code from the extensible task editor classes in the sandbox. Note that I have temporarily disabled default associations between repositories and markup languages until the configuration UI is moved into main as well. The configuration from the context menu is now available for all repositories and WikiText already works JIRA and Trac!
Comment 8 Steffen Pingel CLA 2008-10-16 23:21:57 EDT 
Created attachment 115335 [details]
patch
Comment 9 Steffen Pingel CLA 2008-10-16 23:22:00 EDT 
Created attachment 115336 [details]
mylyn/context/zip
Comment 10 Steffen Pingel CLA 2008-10-16 23:22:41 EDT 
Done.
Comment 11 David Green CLA 2008-10-17 00:35:17 EDT 
(In reply to comment #7)
> I have moved the extension point and merged the code from the extensible task
> ... snip ....
> available for all repositories and WikiText already works JIRA and Trac!

Nice work!