Bug 243858 - Workflows should be created by default in Workflow folder.
Summary: Workflows should be created by default in Workflow folder.
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Geclipse (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Ashish Thandavan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-12 05:45 EDT by Szymon Mueller CLA
Modified: 2014-01-09 16:01 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Mueller CLA 2008-08-12 05:45:16 EDT
New workflows should be created in the Workflow folder by default (similar to how Connections or Job Descriptions are added to their respective folders by default). 

Even more - if user didn't chose to add Workflow folder at the creation of the project it should be created automaticly when user tries to create first workflow in this project (again similar to Connections in Grid Project View - if you try to create new Connection and Connection folder is not in the project it is created at the start of the New Connection wizard).
Comment 1 Ariel Garcia CLA 2008-08-12 05:52:45 EDT
Just a comment regarding the second suggestion: 

> Even more - if user didn't chose to add Workflow folder at the creation of
> the project it should be created automaticly when user tries to create
> first workflow in this project

this is nice behaviour if the user didn't delete the Workflow (or Connections) folder by hand... otherwise it might be upsetting ;-)
I remember somebody complained in another bug about it... but in any case the behaviour should be unified, it is not nice that each component handles those "default folders" differently.
Suggestions, opinions?
Comment 2 Mathias Stümpert CLA 2008-08-12 06:21:14 EDT
I object against creating folders on the fly! The project folders are a project setting and are as such immutable if not directly changed by the user via project properties. So no, we should not create any folder if it is not present. Leave this to the user.
Comment 3 Ashish Thandavan CLA 2008-08-16 12:05:53 EDT
reassigning to David
Comment 4 David Johnson CLA 2008-08-17 15:35:26 EDT
(In reply to comment #3)
> reassigning to David
> 

Great, reassigned to me, and I guess Ashish has no comment on this issue

(In reply to comment #2)
> I object against creating folders on the fly! The project folders are a project
> setting and are as such immutable if not directly changed by the user via
> project properties. So no, we should not create any folder if it is not
> present. Leave this to the user.
> 

Anyway, OK. So do we let the user create workflows wherever they like then?.
Comment 5 Ashish Thandavan CLA 2008-08-17 15:44:23 EDT
 
> Great, reassigned to me, and I guess Ashish has no comment on this issue

:-) Meant to put in my two cents but forgot!

> 
> Anyway, OK. So do we let the user create workflows wherever they like then?.
> 

I guess the workflow-folder ought to get created wherever the user wants to create his/her workflow.
Comment 6 Ariel Garcia CLA 2008-08-17 15:55:36 EDT
yes, if the user didn't create or removed the default workflows folder then on the top level project. If he is not happy with that he can always go:
  project properties -> grid project folders and create a new one
Comment 7 Mathias Stümpert CLA 2008-09-03 03:33:03 EDT
I'm not quite sure if I understand all the proposals correctly. Nevertheless let me give you a description of how things are implemented for the connections, jobs etc.

1) If a project folder for element type X is defined in the project's properties and an element of type X is created with the corresponding New-Wizard the default path in the new wizard points to that folder.
2) If no such folder is defined in the project's properties the default path in the new wizard points to the project itself.
3) If no such folder is defined it is NOT generate on the fly!
4) In any case the default path can be changed by the user at creation time, i.e. in the New-Wizard.

This is also the way things like the New-Class wizards are working. There the New-Wizards by default point to the "src" folder (or a subfolder of that if packages are used). But no "src" folder is created on the fly if it is not specified in the project's properties. We should definitely follow this approach.

So I do not know what the current status is (just back from vacation), but

1) If Szymon's first point is solved, i.e. if the new workflow wizard by default points to the wf folder if present or to the project itself otherwise we can close this bug.
2) Regarding Szymon's second point I vote -1!
Comment 8 Ashish Thandavan CLA 2008-09-03 04:00:45 EDT
I'm currently re-working the New Workflow Wizard and will incorporate a fix for this bug.
Comment 9 Ashish Thandavan CLA 2008-10-30 06:40:53 EDT
Just committed a minor edit that fixes this bug. When a user wants to create a new workflow,
1) if a Workflows folder exists in the Grid Project, it is selected as the default folder
2) if it does not exist, the default selection is the Job Descriptions folder.

Please check and comment.
Comment 10 David Johnson CLA 2008-10-30 06:48:42 EDT
Bug #220906 is a duplicate