Bug 243655 - notification window shows last unread comment, not the newest one
Summary: notification window shows last unread comment, not the newest one
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-08-09 07:40 EDT by Patrick Schonbach CLA
Modified: 2009-05-25 23:36 EDT (History)
3 users (show)

See Also:

Attachments
patch (984 bytes, patch)
2009-05-21 16:11 EDT, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (2.16 KB, application/octet-stream)
2009-05-21 16:11 EDT, Frank Becker CLA 		no flags Details
updated patch (12.38 KB, patch)
2009-05-23 15:06 EDT, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (6.99 KB, application/octet-stream)
2009-05-23 15:06 EDT, Frank Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Schonbach CLA 2008-08-09 07:40:20 EDT 
When the notification window pops up, it shows the last unread message, not the newest message that has arrived. This is usually not what you want to see, because if several new messages arrive before you have read them, you always get to see one and the same message. In my opinion, the newest message(s) should be shown.
Comment 1 Steffen Pingel CLA 2008-08-09 15:26:54 EDT 
The notifications are currently displayed in the order returned by the repository. I agree that it would be nice to sort them and possibly also take properties such as the priority of tasks into account.
Comment 2 Patrick Schonbach CLA 2008-08-09 15:39:41 EDT 
Agreed. However, what is bugging me most is that in case of unread comments, the notification keeps displaying one and the same comment, even though, you would like to see what comment really just came in.
Comment 3 Steffen Pingel CLA 2008-08-09 17:14:29 EDT 
Right, showing of the first unread comment was added for tooltips but it makes less sense for notifications. I have tentatively scheduled this for the 3.x release cycle.
Comment 4 Steffen Pingel CLA 2009-04-22 03:35:55 EDT 
Frank, are you interested in looking into this?
Comment 5 Frank Becker CLA 2009-05-21 16:11:13 EDT 
Created attachment 136717 [details]
patch
Comment 6 Frank Becker CLA 2009-05-21 16:11:15 EDT 
Created attachment 136718 [details]
mylyn/context/zip
Comment 7 Steffen Pingel CLA 2009-05-21 22:32:05 EDT 
Frank, I think that some modification to TaskDataDiff.toString() is needed to grab the find the last comment that has changed and not the first one. We do need to make sure though that this does not affect tooltips.
Comment 8 Frank Becker CLA 2009-05-23 15:06:04 EDT 
Created attachment 136893 [details]
updated patch

TaskDataDiff.toString is changed and for testing TestTaskListNotificationAction was changed.

TaskListNotificationQueryIncoming is removed (never used)
Comment 9 Frank Becker CLA 2009-05-23 15:06:07 EDT 
Created attachment 136894 [details]
mylyn/context/zip
Comment 10 Steffen Pingel CLA 2009-05-25 23:36:45 EDT 
Great! Thanks Frank. I have tweaked the test action slightly and committed the patch.