Bug 243304 - [rulers] Make QuickDiff ruler accessible
Summary: [rulers] Make QuickDiff ruler accessible
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.5 RC1   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2008-08-06 09:54 EDT by Markus Keller CLA
Modified: 2009-05-15 06:46 EDT (History)
2 users (show)

See Also:
daniel_megert: review+


Attachments
Fix (14.61 KB, patch)
2009-05-12 11:23 EDT, Markus Keller CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-08-06 09:54:23 EDT
I20080805-1307

The hovers in the QuickDiff ruler, including the CVS Annotation hovers, are not accessible via keyboard / screen reader.

We should add a command that opens the QuickDiff hover for the cursor line, e.g. "Show QuickDiff Description", like Edit > Show Tooltip Description.

Could also add this to the ruler context menu (Ctrl+F10).

See also bug 78244 and bug 236440.
Comment 1 Markus Keller CLA 2009-05-12 11:23:11 EDT
Created attachment 135376 [details]
Fix

Adds a "Show Change Ruler Tooltip" command, which users can bind to a shortcut.

Filed bug 275890 to share the code I had to copy and to make the command ID and constant API.
Comment 2 Dani Megert CLA 2009-05-13 08:13:07 EDT
Nice work!

Some issues I found:
- I know the ATE does it the same (filed bug 276065) but in the new code
  - it would be better to only create the information presenter if need.
  - we should uninstall and dispose it when the editor is closed
- widgetOffset2ModelOffset(...) can return -1; since we catch the case where the
  document might be 'null' we should also catch the -1 case
- makeAnnotationHoverFocusable(...) returns a boolean which is not used
- "comp" is a bad name for a ruler ;-)
- also document private methods
- widgetOffset2ModelOffset
- added note to bug 270475 that we need to document that nothing happens when 
  there's no change
- sticky hover ==> focused hover

+1 for RC1 assuming above items get addressed.
Comment 3 Markus Keller CLA 2009-05-13 11:56:05 EDT
(In reply to comment #2)
Fixed these issues and released to HEAD.

> - sticky hover ==> focused hover
I also fixed this for the existing 'Show Tooltip Description' action.
Comment 4 Markus Keller CLA 2009-05-15 06:46:15 EDT
Verified in I20090514-2000.