Bug 243298 - Show Annotations only marks first line of JavadocHoverStyleSheet.css
Summary: Show Annotations only marks first line of JavadocHoverStyleSheet.css
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-06 09:18 EDT by Markus Keller CLA
Modified: 2019-09-06 15:30 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-08-06 09:18:43 EDT
I20080805-1307

Show Annotations only annotates the first line of /org.eclipse.jdt.ui/JavadocHoverStyleSheet.css

The problem is probably that the file is saved with Mac line delimiters (\r) but I'm opening it in a workspace with Windows delimiters (\r\n).
Comment 1 Markus Keller CLA 2008-08-06 10:04:57 EDT
Also fails on a Mac (with Unix \n as default).
Comment 2 Tomasz Zarna CLA 2008-08-13 06:00:46 EDT
This looks to be caused by the way CVS response looks like. We receive a single line for the whole file, where we should get a message for every line in the file.

Server response:
1.10         (teicher  31-Jul-06): /* Font definitions */\rhtml         { font-family: sans-serif; font-size: 9pt; font-style: normal; font-weight: normal; }\rbody, h1, h2, h3, h4, h5, h6, p, table, td, caption, th, ul, ol, dl, li, dd, dt { font-size:1em; }\rpre				{ font-family: monospace; }\r\r/* Margins */\r...

It appears to me that CVS server ignores single CRs (and probably does the same for single LFs from comment 1) as line ending characters. It would be hard (if possible) to change this on the server, so I guess we'll need to handle this particular issue on the client side.
Comment 3 Markus Keller CLA 2008-08-18 06:50:52 EDT
Is it even legal for the CVS server to store an ASCII-mode (-ko) file with only \r as line delimiter? If not, we can also consider this a server bug and I'll just try to fix the file.
Comment 4 Dani Megert CLA 2008-08-18 07:13:24 EDT
I guess the problem is that the ascii mode wasn't set at the beginning but set later.
Comment 5 Dani Megert CLA 2008-08-18 07:14:52 EDT
>I guess the problem is that the ascii mode wasn't set at the beginning but set
>later.
Don't know whether the server is supposed to fix the file when the ascii/binary property is changed or whether the client is supposed to do the clean up.
Comment 6 Eclipse Webmaster CLA 2019-09-06 15:30:36 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.