Bug 242788 - a lot of popup ends up as null error
Summary: a lot of popup ends up as null error
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-07-31 16:50 EDT by Alban Browaeys CLA
Modified: 2008-08-19 19:20 EDT (History)
1 user (show)

See Also:
Kevin_McGuire: iplog-


Attachments
check if the parent is disposed before setting the parent as the shell (and use display instead if so) (914 bytes, patch)
2008-07-31 16:50 EDT, Alban Browaeys CLA
Kevin_McGuire: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alban Browaeys CLA 2008-07-31 16:50:31 EDT
Created attachment 108896 [details]
check if the parent is disposed before setting the parent as the shell (and use display instead if so)

Build ID: I20080617-2000

Steps To Reproduce:
1. get a site which requires the old installer features
2. try to update via p2
3. a null error appears in the log instead of a popup asking if we want to proceed.


More information:
there are other use case I cannot remind well : taylor model navigator that was detecting broken resources in the package explorer. Errors from vectrace mercurial plugin that did not showed up, etc.

This happens for everything that shows a popup and disappear before it is shown, that is the parent is disposed.
Comment 1 Kevin McGuire CLA 2008-08-19 17:18:27 EDT
Thanks for the patch.  Seems like a reasonable safe guarding fix, although I think its showing bugs elsewhere.  Alban, did you report your test case as a bug to p2?
Comment 2 Kevin McGuire CLA 2008-08-19 18:08:11 EDT
Patch released as IconAndMessageDialog 1.29
Comment 3 Kevin McGuire CLA 2008-08-19 19:20:27 EDT
(correcting iplog flags, should've been on patch, not on the bug)