Bug 242296 - Add "Edit > Copy Qualified Name" action to Synchronize View
Summary: Add "Edit > Copy Qualified Name" action to Synchronize View
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-07-28 15:45 EDT by Scott Cowan CLA
Modified: 2020-02-14 11:23 EST (History)
3 users (show)

See Also:


Attachments
New action based off CopyToClipboardAction (15.45 KB, patch)
2008-07-28 15:45 EDT, Scott Cowan CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Cowan CLA 2008-07-28 15:45:09 EDT
Created attachment 108563 [details]
New action based off CopyToClipboardAction

Build ID: 3.4.0  I20080617-2000

Steps To Reproduce:
On my team, whenever we fix a bug, we list the files that were modified to fix the bug in the resolution.  I've created a patch to org.eclipse.team.ui that allows me to "Edit > Copy Qualified Name" of all the files I've touched in the Synchronize View.  This makes it much easier to copy/paste the result.

More information:
Could we consider the attached patch, or at least the spirit of it, for a feature in an upcoming release?
Comment 1 Tomasz Zarna CLA 2008-07-29 06:46:21 EDT
Scott, the patch works fine, but I have some comments:
1. First of all, have you looked at the original "Copy Qualified Name" action[1] from jdt.ui? What I can see from the code you enhanced the CopyToClipboardAction from team.ui, which is fine. However, I belive that the original action from JDT is a better example. Of course, to make it work as expected you will need to mixed them both.
2. The getSelectedResources() method returns IResources. What about non-Resources? Guys from JDT handle also their own specific types like IJavaProject. I guess this kind of types don't appear in the Sync view while in Workspace Model mode, however I'm not sure if IResource is the only thing that you can come across.
3. The icon should be the same as for the "original" Copy Qualified Name action. It's slightly different, you can find it here: /org.eclipse.jdt.ui/icons/full/elcl16/cpyqual_menu.gif

Please, don't get me wrong, I like the idea, and it would be great if we could make it a part of a next release. Let me know what do you think about my comments and whether you want to adjust your patch by yourself or want me to do it (I can't say when I would do it, though. I have to focus on 3.4.1 bugs).

Thanks again

[1] org.eclipse.jdt.internal.ui.actions.CopyQualifiedNameAction in org.eclipse.jdt.ui
Comment 2 Scott Cowan CLA 2008-07-30 15:09:46 EDT
I knew I skirted some details when I whipped up this proof of concept.  I will try to improve on this patch with your suggestions.
Comment 3 Eclipse Genie CLA 2020-02-14 11:23:58 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.