Bug 242057 - [Net] Default preference gets ignored
Summary: [Net] Default preference gets ignored
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Wojciech Galanciak CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-25 05:55 EDT by Markus Kuppe CLA
Modified: 2010-10-19 08:51 EDT (History)
5 users (show)

See Also:
Szymon.Brandys: review+

Attachments
patch (36.47 KB, patch)
2010-09-27 09:15 EDT, Wojciech Galanciak CLA 		no flags Details | Diff
updated patch (43.41 KB, patch)
2010-10-06 12:52 EDT, Wojciech Galanciak CLA 		Szymon.Brandys: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2008-07-25 05:55:50 EDT 
As stated in https://bugs.eclipse.org/bugs/show_bug.cgi?id=217663#c3 the UI doesn't honor what is set via default preferences (e.g. via plugin_customization.ini etc.). This would be especially useful in headless mode though.
Currently one needs to create the $osgi.configuration.area/.settings/org.eclipse.core.net.prefs first (which feels like using internal API).
Comment 1 Pawel Pogorzelski CLA 2008-10-03 10:47:38 EDT 
The proxy preferences from plugin_customisation.ini doesn't get load because ProxyManager looks for settings directly in a configuration scope node.

For this facility to work also default scope has to be searched. I will provide a patch as soon as I come up with a proper solution.
Comment 2 Pawel Pogorzelski CLA 2008-11-21 05:58:16 EST 
The change appeared to be more complex since there is code that explicitly walks through configuration scope nodes.

No time to address the issue right now. Maybe someone is willing to help...
Comment 3 Wojciech Galanciak CLA 2010-09-27 09:15:06 EDT 
Created attachment 179635 [details]
patch

This patch provides support for default values of proxy preferences. Main features:
- possibility to provide default settings through -pluginCustomization which allows to use proxy settings in headless mode,
- separation of direct operations on preferences to PreferencesManager - interaction with preferences only by using its public methods
- ability to get default values of proxy settings for e.g. full functional Restore Defaults button (bug 283036).
Comment 4 Wojciech Galanciak CLA 2010-10-06 12:52:36 EDT 
Created attachment 180349 [details]
updated patch
Comment 5 Szymon Brandys CLA 2010-10-07 07:24:56 EDT 
Now it looks good. Thanks Wojtek.
Comment 6 Dani Megert CLA 2010-10-19 08:51:25 EDT 
This fix is not good. It causes exceptions, see bug 327672.