Bug 242022 - [hovering] Annotation popup is long and does not wrap or show scrollbars
Summary: [hovering] Annotation popup is long and does not wrap or show scrollbars
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on: 56342
Blocks:
  Show dependency tree
 
Reported: 2008-07-24 15:48 EDT by Remy Suen CLA
Modified: 2019-11-14 03:27 EST (History)
4 users (show)

See Also:


Attachments
The screenshot of the problem. (38.33 KB, image/jpeg)
2008-07-24 15:49 EDT, Remy Suen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2008-07-24 15:48:24 EDT
The screenshot is from Vista although I can reproduce it on Linux/gtk+ on I20080716-1200 (not sure what my Vista build is, at least 3.4 or a later I build).

I was told by CVS to file the bug to Text first to see whether it's a Text problem or not. And if isn't, could Text then move it to CVS with some tips on how to fix the problem? :)

As you can see from the attachment, the popup is ridiculously long with no sign of word wrapping (or horizontal scrollbars) in sight.

Hitting F2 (talking about Linux here since I'm not using Vista right now) will resize it down properly and horizontal scrollbars have appeared for me to scroll down. Although, technically I'd prefer it just word wrap the thing instead of forcing me to scroll horizontally, but I guess that's a different problem.

To reproduce the problem, you can checkout org.eclipse.ecf/plugins/org.eclipse.ecf.docshare from /cvsroot/technology. Then open the org.eclipse.ecf.internal.provisional.docshare.DocShare class and then use the context menu to call 'Show Annotations'. Hovering around line 128 or so should do.
Comment 1 Remy Suen CLA 2008-07-24 15:49:05 EDT
Created attachment 108390 [details]
The screenshot of the problem.

Attaching failed at creation, I hope this works.
Comment 2 Remy Suen CLA 2008-07-24 20:08:57 EDT
(In reply to comment #0)
> To reproduce the problem, you can checkout
> org.eclipse.ecf/plugins/org.eclipse.ecf.docshare from /cvsroot/technology. Then
> open the org.eclipse.ecf.internal.provisional.docshare.DocShare class and then
> use the context menu to call 'Show Annotations'. Hovering around line 128 or so
> should do.

Actually, you don't even have to checkout the projects since you can just browse to that file through the 'CVS Repository Browsing' view and invoke 'Show Annotations' from there.
Comment 3 Markus Keller CLA 2008-07-28 06:40:37 EDT
Dani, I'm unsure how we should suggest to fix this problem (which we introduced with our patch to bug 228671).

There are basically two solutions:

(1) Add official support for SWT.WRAP style in DefaultInformationControl (needs some work for the resizable case and will look a bit strange in that case because a StyledText with SWT.WRAP has only a vertical but no horizontal scroll bar).

(2) Offer an implementation of DefaultInformationControl.IInformationPresenterExtension as API, which uses a LineBreakingReader to insert hard line breaks into the given text (something like HTMLTextPresenter but without interpreting HTML and considering and updating the existing styles from the given TextPresentation).
Comment 4 Dani Megert CLA 2008-07-30 10:27:34 EDT
We should go for 1) but if possible with a new constructor instead of un-deprecating the old and tweak SWT.WRAP. Also, we could add a hack to make the horizontal scroll bar visible.
Comment 5 Remy Suen CLA 2008-07-30 10:32:13 EDT
I think 1 would be nice. This would allow it to be reused for completion proposal's getAdditionalProposalInfo() and/or getAdditionalProposalInfo(IProgressMonitor).
Comment 6 Markus Keller CLA 2009-04-30 12:31:46 EDT
I'll try to look at this in RC1, otherwise 3.6.
Comment 7 Dani Megert CLA 2009-05-19 10:12:46 EDT
Touching that code in RC2 is too risky. Moving to 3.6.
Comment 8 Dani Megert CLA 2011-04-12 06:27:14 EDT
Markus, it would be nice to see this in M7. 3.8 otherwise.
Comment 9 Lars Vogel CLA 2019-11-14 03:27:40 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.