Bug 241 - LOST WORK: Replace from team stream should save history before replacing (1GJL5HD)
Summary: LOST WORK: Replace from team stream should save history before replacing (1GJ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P5 normal (vote)
Target Milestone: 2.0 M4   Edit
Assignee: Jean-Michel Lemieux CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 21:38 EDT by Jerome Lanneluc CLA
Modified: 2002-04-10 15:28 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2001-10-10 21:38:46 EDT
1. Catch up with your team stream
	2. Select a file, make a modification to this file and save it
	3. Replace this file from team stream
	4. Replace with local history
	Observe: Your change is not present in the local history

	Replace from team stream should save the current version of the file to the local history
	before replacing it.

NOTES:

KM (9/6/2001 12:24:52 PM)
	Saving the file should put in local history.
	It should already be in there before you do "Replace from stream", and available for recovery,
	so as I understand this PR its not VCM.

	Moving to ITPUI to investigate whether saving always puts in local history.

EJP (9/10/2001 10:49:07 AM)
	Core does not keep a copy of the current file in the local history. Only when
	the file is saved a second time that the the first version goes to local history.

	When you replace the file with the current stream contents you have to
	call the core API delete or setContent passing keepHistory equas true.

KM (9/10/2001 2:14:02 PM)
From email with Eduardo

>Do you mean that in Step 2 in the PR  that saving the file does not add it to local history?

	Yes. It saves the old version to the history not the one that you just saved.

>This seems kind of odd if true. 

	I agree. I do not like the API either.

>It means that you can't rely on the new contents being in history 

	True.

>and must 
>save prior to all destructive operations (eg. it means I must save to local history prior to deletion).  Yes?

	It means that you have to decide what you want to do in the "destructive operations".

	You have the  API delete(...) in IResource which will NOT keep the local history (I think it should be changed)
	and you have the API in IFile which receives the boolean parameter "keepHistory". The same for setContents(...)

Eduardo.
Comment 1 DJ Houghton CLA 2001-10-23 23:48:22 EDT
PRODUCT VERSION:
	134

Comment 2 James Moody CLA 2001-10-25 17:22:48 EDT
See also bug 113.
Comment 3 Jean-Michel Lemieux CLA 2002-03-14 15:50:38 EST
Fixed.
Comment 4 Jean-Michel Lemieux CLA 2002-04-09 13:31:44 EDT
testing workflow
Comment 5 Jean-Michel Lemieux CLA 2002-04-10 15:28:47 EDT
Fixed again. We save local history.