Bug 240336 - [package explorer] Delete warnings differ from other views
Summary: [package explorer] Delete warnings differ from other views
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P4 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-10 10:32 EDT by Dani Megert CLA
Modified: 2023-06-05 06:56 EDT (History)
1 user (show)

See Also:


Attachments
Fix (11.19 KB, patch)
2008-07-10 10:34 EDT, Dani Megert CLA
no flags Details | Diff
Fix (2.44 KB, patch)
2008-07-10 10:54 EDT, Dani Megert CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-07-10 10:32:02 EDT
R3.4.

The Navigator and Project Explorer tell the user that a file or folder is removed from the file system while the Package Explorer doesn't. This can result in unexpected deletion from disk.
Comment 1 Dani Megert CLA 2008-07-10 10:32:35 EDT
See also bug 234959.
Comment 2 Dani Megert CLA 2008-07-10 10:34:39 EDT
Created attachment 107083 [details]
Fix
Comment 3 Dani Megert CLA 2008-07-10 10:54:22 EDT
We should fix this in two steps:
1. make sure we show the 'from file system' (3.4.1, this bug)
2. show the type of deleted resource. The Package Explorer almost does this,
   only the project deletion (which comes from the LTK) doesn't do this.
   ==> will not be fixed for 3.4.x. Tracked by bug 240342.
Comment 4 Dani Megert CLA 2008-07-10 10:54:45 EDT
Created attachment 107086 [details]
Fix
Comment 5 Markus Keller CLA 2008-07-10 13:35:25 EDT
First 2 changes look good, but 3rd is problematic:
DeleteWizard_9=Are you sure you want to delete these {0} elements from the file system?

This message is used for all kinds of multselection, also e.g. for two Java methods, where "from the file system" is wrong. Can only be fixed well with an additional message (like bug 239425).
Comment 6 Dani Megert CLA 2008-07-14 09:28:09 EDT
>This message is used for all kinds of multselection, also e.g. for two Java
>methods,
The patch is already wrong if only one method is selected. Especially if this method isn't yet saved.

Suggest to live with the current implementation for now. Otherwise we'd need a complete rework of this.

Markus?
Comment 7 Markus Keller CLA 2008-07-14 09:59:05 EDT
> Suggest to live with the current implementation for now.
+1

Comment 8 Eclipse Genie CLA 2019-05-24 17:08:53 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 9 Eclipse Genie CLA 2021-05-19 02:49:15 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 10 Eclipse Genie CLA 2023-06-05 06:56:30 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.