Bug 239425 - [ltk] Strange confirmation message on 'Delete project'
Summary: [ltk] Strange confirmation message on 'Delete project'
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-03 06:32 EDT by Martin Aeschlimann CLA
Modified: 2008-07-14 09:14 EDT (History)
1 user (show)

See Also:

Attachments
patch (3.73 KB, patch)
2008-07-03 06:37 EDT, Martin Aeschlimann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2008-07-03 06:32:51 EDT 
3.4

- Select a project and press 'Delete'
- A dialog asks you if you are sure to delete the resource from the file system, but still offers you a check box to decide if the project is really removed from disk.

The bug got introduced by fix for bug 234959.

We should revert the message to what it was in 3.3.
Comment 1 Martin Aeschlimann CLA 2008-07-03 06:37:25 EDT 
Created attachment 106419 [details]
patch

The patch changes the to dialog labels the following messages (single/multiple delete)

Are you sure you want to remove project ''{0}'' from the workspace?
Are you sure you want to remove these {0} projects from the workspace?

I think this is better than what we had in 3.3:

Are you sure you want to delete project ''{0}''
Comment 2 Martin Aeschlimann CLA 2008-07-03 06:38:16 EDT 
released for 3.5 > 20080307

Should also fix in 3.4.1
Comment 3 Dani Megert CLA 2008-07-10 10:29:39 EDT 
Agree that it looks a bit strange but unfortunately we can only fix this by introducing a new NLS string key. We have to make sure that we don't introduce missing strings in non-English 3.4.1. I'll have to double-check that before we commit this to 3.4.1.
Comment 4 Dani Megert CLA 2008-07-14 09:14:43 EDT 
Sorry, not for 3.4.x.