Bug 23889 - [Markers] Multi-select on Task doesn't allow quickfix
Summary: [Markers] Multi-select on Task doesn't allow quickfix
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0.1   Edit
Hardware: All All
: P2 enhancement with 17 votes (vote)
Target Milestone: 3.2 M4   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 28635 44707 45333 47732 50132 58690 74942 87217 91594 101234 (view as bug list)
Depends on: 114570 114754
Blocks:
  Show dependency tree
 
Reported: 2002-09-20 04:02 EDT by Ricardo Jorge PC de Almeida CLA
Modified: 2005-12-13 11:27 EST (History)
26 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ricardo Jorge PC de Almeida CLA 2002-09-20 04:02:02 EDT
When selecting several Tasks, and then pressing the right mouse button, the
quick fix option is unavailable. I'd suggest that if selecting Tasks that suffer
from the same problem (ex: Local addition not under CVS control), the quick fix
option should be available and the solution choosed applyed to all.
Comment 1 Dan Kehn CLA 2002-12-02 15:33:26 EST
Agreed, and here's a related issue.  Creating a new project in CVS, I have 40+ 
entries for "add to local CVS".  After doing so (not using Quick Fix), the 
Quick Fix entries still are there.

I propose (a) that the Quick Fix in this particular case should go away 
automatically, (b) there should be a means to delete "informational" Task list 
messages -- not just filter them, and (c) as this bug suggests, Quick Fix from 
the Task list should all multi-select, even if it prompts for each (not ideal, 
but better than it is today).
Comment 2 Eric Estievenart CLA 2003-10-12 00:00:06 EDT
*** Bug 44707 has been marked as a duplicate of this bug. ***
Comment 3 Debbie Wilson CLA 2003-10-23 10:26:11 EDT
*** Bug 45333 has been marked as a duplicate of this bug. ***
Comment 4 Jamie Bisotti CLA 2003-10-23 10:38:59 EDT
I'd like to take this a step further and not limit this to "Quick Fix".  Seems
like the "Go To" and possibly "Properties" functions should also work when
multiple items are selected.
Comment 5 Martin Aeschlimann CLA 2004-01-09 09:13:53 EST
*** Bug 47732 has been marked as a duplicate of this bug. ***
Comment 6 Martin Aeschlimann CLA 2004-01-19 03:55:38 EST
*** Bug 50132 has been marked as a duplicate of this bug. ***
Comment 7 Benjamin Hill CLA 2004-01-19 08:45:29 EST
People so far in the discussion seem to prefer the "Select several problems, 
and if they are all the same type, still allow quick-fixes from the right 
click menu."  I've also seen another way to do multiple in another UI, where 
if you select one and choose quick-fix, and if there are other items of the 
same type, there is an additional default unchecked checkbox in the popup 
of "Apply fix to all other items of same type?" 

I think the multiple select method is better because it allows you a finer 
grain control to only fix a few items of a type at once, but I think more 
people would stumble across the checkbox method.  Personally, I'd prefer both.
Comment 8 Dirk Baeumer CLA 2004-04-16 05:44:09 EDT
*** Bug 58690 has been marked as a duplicate of this bug. ***
Comment 9 Robert (Kraythe) Simmons CLA 2004-09-20 16:49:10 EDT
I would be happy to have this ASAP. Fixing 20000 "Unqualified access to 
member" problems in a legacy project is NOT fun right now. 
Comment 10 Markus Keller CLA 2004-09-24 09:12:38 EDT
*** Bug 74942 has been marked as a duplicate of this bug. ***
Comment 11 Nils Hammar CLA 2004-10-26 10:22:04 EDT
This bug is still present in 3.1 I20041013!!!

(I think that this "bug" should get raised to a higher priority, since I'm also
stuck with the "Unqualified access..." mess!)
Comment 12 tonis CLA 2005-01-26 17:09:22 EST
Ok would be if user clicks and there is option in menu 'quick fix all items of
this type', also possible grouping of similar items in tree. Fixing different
type problems at once is too tricky and some problems can't be quick fixed. And
some problems should have grouped quick fix and some shouldn't ...

Interesting is that fixing this seems a probalem b/c I'm sure Eclipse has needed
code editing and rebuilding infrastructure. Applying transformations in sequence
and changing UI little shouldn't take much longer than couple of days for one
who knows related code well?  
Comment 13 Carl Rosenberger CLA 2005-01-26 17:17:20 EST
Risking spamming the person in charge, I second tonis latest suggestions. I 
have been on the list for this bug from the very start (having posted a 
duplicate) which means I have been waiting for a fix for more than TWO YEARS. 
Please finally have a go at this, we need it almost every day.
Comment 14 Gary Gregory CLA 2005-01-26 18:45:55 EST
I posted a dup a long time ago too. This would be a great enhancement.
Comment 15 Dirk Baeumer CLA 2005-03-06 13:54:31 EST
*** Bug 87217 has been marked as a duplicate of this bug. ***
Comment 16 Dirk Baeumer CLA 2005-04-16 10:23:34 EDT
*** Bug 91594 has been marked as a duplicate of this bug. ***
Comment 17 Dirk Baeumer CLA 2005-06-22 12:08:09 EDT
*** Bug 101234 has been marked as a duplicate of this bug. ***
Comment 18 Benjamin Hill CLA 2005-07-18 20:11:28 EDT
Any word from the powers that be?  I have a project with around 1k (yes
thousand) quick fixes, 80% of which could use the batch fixing.  Is this on
anyone's horizon?  If not, is anyone on the CC list interested in collaborating
on a temporary workaround/hack/plug in to do quick fixes?  If so, feel free to
contact me directly.
Comment 19 Markus Keller CLA 2005-07-19 06:10:50 EDT
Here's a list of JDT quick fixes that have been mentioned in duplicates and that
would profit from batch processing:
- Remove unused import
- Unqualified access to member
- extra semicolons
- unnecessary cast or instanceof
- create missing constructors
- access to static members through non-static contexts
- missing serialVersionUID
Comment 20 David Corbin CLA 2005-07-19 06:34:26 EDT
Why should it be limited?  I should be able to multi-select ANY problem marker
and quick fix them.  It might be necessary to limit multi-select to common markers.
Comment 21 Markus Keller CLA 2005-07-19 06:51:51 EDT
I didn't say that the list from comment 19 should be closed. I just wanted to
show that there are a bunch of quick fixes that could be applied in batch (I
e.g. also forgot the 5.0 quick fixes to add @Override or @SuppressWarnings).

Still, not all quick fixes will be amenable to be applied to multi-selections.
E.g. if you have an error like in ...
        new Integer(1, "2");
..., then you can't tell which quick fix 'Remove argument to match Integer(..)'
should be applied.
Comment 22 Danny Yates CLA 2005-09-26 10:37:48 EDT
Hi,

Can we get a status update on this, please? Part of my role is to migrate lots 
of development teams from JBuilder to Eclipse, and face the dreaded import-
project-and-fix-loads-of-serializable-warnings problem almost daily. This would 
be a big productivity gain for me.

Thanks
Comment 23 Tod Creasey CLA 2005-09-26 11:22:47 EDT
There has been no changes to the status since the last comments.
Comment 24 Tod Creasey CLA 2005-09-26 11:31:46 EDT
Given it's immense popularity I am going to upgrade the priority.
Comment 25 Sergey Vladimirov CLA 2005-09-27 03:38:20 EDT
Please, mark 30204 as dublicate of this.
Comment 26 Tod Creasey CLA 2005-09-29 12:25:57 EDT
Fixed in build >20050929. It will now handle mutli select and only prompt if
there is more than one quick fix for a marker.
Comment 27 Danny Yates CLA 2005-09-29 12:57:43 EDT
I'm currently running 3.2M2. Can you please point me at the instructions for 
patching it with the relevant M/I build, please?
Comment 28 Tod Creasey CLA 2005-09-29 13:26:33 EDT
I only released the change an hour ago - it will be in builds starting tonight.

If you want to look at it load ActionResolveMarker from HEAD
Comment 29 Danny Yates CLA 2005-09-29 14:07:30 EDT
Sorry, I wasn't clear. Once an N build is available with the fix in, how do I 
apply that to my current 3.2M2 installation?
Comment 30 Tod Creasey CLA 2005-09-29 14:17:40 EDT
The easiest way is to just take the new build and use it with your existing
workbench. If you want you could always copy the ide plug-in over but there are
no guarantees that this not break due to other dependencies.
Comment 31 Benjamin Hill CLA 2005-09-29 14:38:59 EDT
(Tod is my hero)

Any thoughts on comment 7?
Comment 32 Tod Creasey CLA 2005-09-29 15:23:01 EDT
I think it is a pretty good idea - the only reason I didn't do it was fear that
this feature would get pushed to the background by the other work we are doing
and not get into 3.2. I didn't want to miss a feature with 21 votes!

Please feel free to log another bug for this idea if you would think it is
interesting.
Comment 33 Tod Creasey CLA 2005-11-01 10:18:29 EST
Verified in 20051101
Comment 34 Tod Creasey CLA 2005-11-02 09:10:27 EST
Reopening. We are going to need to add API for teams to buy into this as it is
making some problems show up for resolution providers.
Comment 35 Tod Creasey CLA 2005-11-02 09:11:41 EST
*** Bug 28635 has been marked as a duplicate of this bug. ***
Comment 36 Daniel Lindner CLA 2005-11-02 09:22:31 EST
Thanks for the progress on this. I've been awarded with the nickname "hunter of
the missing this" because of this feature missing.
I also tried to patch it on my own, but without significant API change, this is
quite a tough task.
Thanks, Tod.
Comment 37 Tod Creasey CLA 2005-11-02 09:27:55 EST
Daniel if you have some input into the API I will propose in Bug 114754 please
let us know there. I will be looking into this in the next week or so.
Comment 38 Markus Keller CLA 2005-11-02 09:33:23 EST
(In reply to comment #36)
Daniel: For java-specific quick fixes, also check out the new
'Source > Clean Up...' action that has been added for 3.2M3.
Comment 39 Tod Creasey CLA 2005-11-16 16:54:27 EST
For performance reasons I will not be enabling multi select from the menu but
will have it as an option to add from the dialog. 

This will allow you to add all similar markers in your problems view so that you
can fix multiple instances of the same problem at once. This is easier than
using the selection to build the list as the user does not have to hunt and peck
for all of the instances of a problem.

Currently only my test marker resolutions support this - if JDT changes thier
resolution to be WorkbenchMarkerResolutions and allows grouping we will be able
to mullti fix thenthen.
Comment 40 Tod Creasey CLA 2005-12-13 11:27:21 EST
verified in 20051213-0100