Bug 238762 - REFRESH button in a dialog
Summary: REFRESH button in a dialog
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact: Tomasz Zarna CLA
URL:
Whiteboard:
Keywords: helpwanted
: 279714 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-27 06:11 EDT by Dominik Skorka CLA
Modified: 2019-09-06 15:30 EDT (History)
3 users (show)

See Also:


Attachments
Patch v01 (2.54 KB, patch)
2009-05-26 12:00 EDT, Tomasz Zarna CLA
no flags Details | Diff
mylyn/context/zip (14.68 KB, application/octet-stream)
2009-05-26 12:00 EDT, Tomasz Zarna CLA
no flags Details
Patch v02 (4.59 KB, patch)
2009-07-14 08:21 EDT, Tomasz Zarna CLA
no flags Details | Diff
mylyn/context/zip (9.99 KB, application/octet-stream)
2009-07-14 08:22 EDT, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Skorka CLA 2008-06-27 06:11:37 EDT
When I need to update my project I usually follow: right click over the project in 'Package Explorer' -> Team -> Update. When it turns out that my workspace is unsynchronized then I am presented a pop-up 'Problem Occurred' saying: 'CVS Update' has encountered a problem. There is also an advice: 'Perform a Refresh'.

Fair enough, but this is a bit annoying to seek for a refresh while a dedicated button should be available for a user in the pop-up (next to 'Show CVS console' 'OK' 'Details' buttons).

Well, for me this would improve a user experience a lot.
Comment 1 Tomasz Zarna CLA 2008-07-02 11:05:57 EDT
Szymon, is there a way to add a custom button to the Problem Occurred dialog? It is part of the error handling facility, isn't it?
Comment 2 Szymon Brandys CLA 2009-05-25 10:31:37 EDT
(In reply to comment #1)
> Szymon, is there a way to add a custom button to the Problem Occurred dialog?
> It is part of the error handling facility, isn't it?

We're able to add a button with a custom action to the status/error dialog. However AFAIK this would work only in some cases. Krzysztof is the right person to elaborate.

We need to know if the "Problem Occurred dialog" is our new status dialog and how the problem is reported to the status handling facility.

Comment 3 Krzysztof Daniel CLA 2009-05-26 07:53:52 EDT
There can be only one action associated with a job. In case of CVS job, the place is already used by "Show CVS Console".

Currently there is no technical possibility to add more recovery actions, however it would be a nice thing to have.
Comment 4 Tomasz Zarna CLA 2009-05-26 10:33:24 EDT
(In reply to comment #3)
> Currently there is no technical possibility to add more recovery actions,
> however it would be a nice thing to have.

Too bad. Is there a request for such a feature in status handling facility already?

Comment 5 Krzysztof Daniel CLA 2009-05-26 10:48:08 EDT
No, there is not. You can open one ;-).
Comment 6 Tomasz Zarna CLA 2009-05-26 11:57:23 EDT
Krzysztof, told me offline that I could simply configure the job with job.setProperty(IProgressConstants.ACTION_PROPERTY, new RefreshAction()). I've taken a closer look at how it works and it appears that only two team operations override getGotoAction() method and use it display CVS Console. These operations are CheckoutOperation and RepositoryProviderOperation. Overriding the same method in UpdateAction and providing a refresh action should do the job.
Comment 7 Tomasz Zarna CLA 2009-05-26 12:00:25 EDT
Created attachment 137183 [details]
Patch v01

Patch implementing the idea mentioned above, haven't test it yet.

Dominik, would you like to give it a try? :)
Comment 8 Tomasz Zarna CLA 2009-05-26 12:00:34 EDT
Created attachment 137184 [details]
mylyn/context/zip
Comment 9 Dominik Skorka CLA 2009-05-27 13:30:51 EDT
(In reply to comment #7)
> Created an attachment (id=137183) [details]
> Patch v01
> 
> Patch implementing the idea mentioned above, haven't test it yet.
> 
> Dominik, would you like to give it a try? :)
> 

Hi Tomasz.

I am glad that this little feature did not turn out a mission impossible :) And yes, I would like to see it in action unless you ask me to make a build on my own. If so, I will wait for a (nightly/dev) build.

Best regards and thank you!
Comment 10 Tomasz Zarna CLA 2009-05-28 04:48:54 EDT
(In reply to comment #9)
> unless you ask me to make a build on my
> own. If so, I will wait for a (nightly/dev) build.

I must admit this was my intention :) In this case we will have to wait til 3.5 ships.
Comment 11 Tomasz Zarna CLA 2009-06-10 04:03:17 EDT
*** Bug 279714 has been marked as a duplicate of this bug. ***
Comment 12 Tomasz Zarna CLA 2009-07-14 08:21:58 EDT
Created attachment 141506 [details]
Patch v02
Comment 13 Tomasz Zarna CLA 2009-07-14 08:22:02 EDT
Created attachment 141507 [details]
mylyn/context/zip
Comment 14 Tomasz Zarna CLA 2009-08-03 05:16:10 EDT
Before releasing the patch I would like to find out if "Refresh" is an appropriate "recovery" action for any exception that can be handled this way and thrown during an update. I'm not 100% sure of that so I will need extra time to double check this, which unfortunally I haven't found during 3.6M1. Help wanted...
Comment 15 Tomasz Zarna CLA 2010-01-28 07:49:16 EST
We haven't got time to verify safety of the fix, removing the target milestone to better much the reality. Still, any help would be appreciated.
Comment 16 Eclipse Webmaster CLA 2019-09-06 15:30:38 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.