Bug 238616 - OpenJ2EEResourceAction opens blank binary DD for JARs added by Java EE Module Dependencies properties page
Summary: OpenJ2EEResourceAction opens blank binary DD for JARs added by Java EE Module...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-06-26 11:21 EDT by Ian Tewksbury CLA
Modified: 2008-07-16 22:09 EDT (History)
1 user (show)

See Also:
cbridgha: review+

Attachments
patch (2.69 KB, patch)
2008-07-11 10:25 EDT, Ian Tewksbury CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2008-06-26 11:21:01 EDT 
This bug found after fixing Bug 238264

Once a binary module has been added form an external or internal source using the Java EE Module Dependencies page if you then try to access the binary modules deployment descriptor with OpenJ2EEResourceAction a blank file is opened.

The scenario for opening the binary Deployment Descriptors was originally fixed by Bug 237794
Comment 1 Ian Tewksbury CLA 2008-07-11 10:25:42 EDT 
Created attachment 107202 [details]
patch

The issue was actually in BinaryEditorUtilities and the way in which it found and opened the archives containing the binary DDs.

Patch allows BinaryEditorUtilities to created JarEditorInput for files in archives outside of the workspace.
Comment 2 Chuck Bridgham CLA 2008-07-16 10:24:28 EDT 
Nice job.. patch looks good
Comment 3 Carl Anderson CLA 2008-07-16 22:09:31 EDT 
Committed to R3_0_maintenance