Bug 238264 - Addition of binary modules to EAR is not reflected in DD
Summary: Addition of binary modules to EAR is not reflected in DD
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-06-24 11:03 EDT by Ian Tewksbury CLA
Modified: 2008-07-02 23:55 EDT (History)
3 users (show)

See Also:
jsholl: review+
cbridgha: review+


Attachments
Patch (13.43 KB, patch)
2008-06-26 11:03 EDT, Ian Tewksbury CLA
no flags Details | Diff
Updated Patch (12.37 KB, patch)
2008-06-26 11:10 EDT, Ian Tewksbury CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2008-06-24 11:03:17 EDT
Steps:
Create an EAR 5.0 project with DD
Open the project properties
Open "Java EE Module Dependencies"
Click "Add External JAR"
choose an external module JAR (EJB,AppClient,Web, or Connector)
Click apply

The newly added dependency is not reflected in the EARs DD.
Comment 1 Ian Tewksbury CLA 2008-06-24 12:16:53 EDT
(In reply to comment #0)
> Steps:
> Create an EAR 5.0 project with DD
> Open the project properties
> Open "Java EE Module Dependencies"
> Click "Add External JAR"
> choose an external module JAR (EJB,AppClient,Web, or Connector)
> Click apply
> 
> The newly added dependency is not reflected in the EARs DD.
> 

Same result with any version EAR, not just 5.0
Comment 2 Ian Tewksbury CLA 2008-06-26 11:03:48 EDT
Created attachment 105917 [details]
Patch

With this patch any jar added with the Java EE Module Dependencies properties page will now be reflected in the DD.

Tested with many different EAR versions and module versions, exportation works in all cases

Limitations:
1. When attempting to open the deployment descriptor for any of the added jars they open up as blank, but they still export correctly, will open separate bug

2. Weird behavior if user attempts to add two jars in different locations with the same name, will open another bug for this as well
Comment 3 Ian Tewksbury CLA 2008-06-26 11:10:08 EDT
Created attachment 105919 [details]
Updated Patch

The previous patch contained a change in VirtualArchiveComponent that was not actually needed.
Comment 4 Ian Tewksbury CLA 2008-06-26 11:25:36 EDT
Opened:

Bug 238616 - OpenJ2EEResourceAction opens blank binary DD for JARs added by Java EE Module Dependencies properties page

Bug 238617 - Java EE Moudle Dependency properties page should allow adding JARs with same name in different locations
Comment 5 Chuck Bridgham CLA 2008-07-02 12:36:36 EDT
approve
Comment 6 Carl Anderson CLA 2008-07-02 23:55:32 EDT
Committed to R3_0_maintenance