Bug 238302 - [wikitext] review WikiText user guide documentation
Summary: [wikitext] review WikiText user guide documentation
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 minor (vote)
Target Milestone: 3.1   Edit
Assignee: David Green CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 242981 244215 247388
Blocks: 244650
  Show dependency tree
 
Reported: 2008-06-24 13:58 EDT by David Green CLA
Modified: 2008-12-04 14:31 EST (History)
2 users (show)

See Also:


Attachments
mylyn/context/zip (1.73 KB, application/octet-stream)
2008-10-02 23:57 EDT, David Green CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Green CLA 2008-06-24 13:58:45 EDT
Documentation should be available as Ecilpse help, and context help should also be configured.

Please review https://textile-j.dev.java.net/source/browse/*checkout*/textile-j/branches/mylyn.wikitext/java/org.eclipse.mylyn.wikitext.ui/help/Mylyn%20WikiText%20User%20Guide.textile
Comment 1 Steffen Pingel CLA 2008-08-04 21:29:13 EDT
The WikiText guide shows up in the Eclipse help and is now automatically generated as part of the build. I have created bug 242981 to move it under the Mylyn node.
Comment 2 Steffen Pingel CLA 2008-08-14 20:09:38 EDT
To generate the user guide run build-helper.xml as an Ant Build from Eclipse. If you launch a runtime workspace the user guide will appear under the Mylyn node in the Eclipse help.
Comment 3 Mik Kersten CLA 2008-10-01 22:55:12 EDT
David: Please go ahead and add this as you see fit.  We'll just update the docs accordingly with any restructuring (bug 246387).  If you're making major changes or additions just holler to get input berfore doing so.
Comment 4 David Green CLA 2008-10-01 23:25:12 EDT
(In reply to comment #3)
> David: Please go ahead and add this as you see fit.  We'll just update the docs
> accordingly with any restructuring (bug 246387).  If you're making major changes
> or additions just holler to get input berfore doing so.

Mik, no problem.  If I understand you correctly this means that I'll be committing in the @org.eclipse.mylyn.help.ui@ project.  Please confirm that this is what you meant.
Comment 5 David Green CLA 2008-10-02 11:34:24 EDT
There are a couple of issues that need fixing, either in the MediaWiki source or in the WikiText parser:

* In the user guide source there is a comment that starts with @<!---@ and ends with @--->@: these should be modified as follows: @<!--@ and @-->@ (one less '-')
* Some lines in the user guide start with a single space.  According to the MediaWiki documentation this indicates preformatted text.  Either the user guide source should be updated, or perhaps we're detecting these cases incorrectly in the WikiText parser.
* Links are problematic.  In the user guide we link using [[Mylyn FAQ]] and [[Mylyn_FAQ]], but WikiText is resolving this to http://wiki.eclipse.org/Mylyn/Mylyn_FAQ when in fact it should be http://wiki.eclipse.org/Mylyn/FAQ.  I'm not sure if this is a bug with WikiText or a problem with the way the links are expressed in the user guide.
* There are a few broken images
Comment 6 Steffen Pingel CLA 2008-10-02 13:56:53 EDT
Please feel free to fix any errors like the malformed HTML comments or the extraneous spaces.

Regarding the FAQ [[Mylyn FAQ]], [[Mylyn_FAQ]] and [[Mylyn/FAQ]] should all be valid links. The page was originally located at Mylyn_FAQ but later moved to Mylyn/FAQ and is now a redirect. It seems that MediaWiki replaces spaces by underscores in internal links. We can standardize on a single convention for linking (e.g. [[Mylyn/FAQ]]) if that helps
Comment 7 David Green CLA 2008-10-02 15:58:41 EDT
(In reply to comment #6)
> Please feel free to fix any errors like the malformed HTML comments or the
> extraneous spaces.

Will do
 
> Regarding the FAQ [[Mylyn FAQ]], [[Mylyn_FAQ]] and [[Mylyn/FAQ]] should all be
> valid links. The page was originally located at Mylyn_FAQ but later moved to
> Mylyn/FAQ and is now a redirect. It seems that MediaWiki replaces spaces by
> underscores in internal links. We can standardize on a single convention for
> linking (e.g. [[Mylyn/FAQ]]) if that helps

that makes sense to me now.  

The [[Mylyn/FAQ]] link looks like it would be the best option.  Or would just [[FAQ]] work?  

Is there a way to test out these changes without making them instantly 'live' and visible to everyone?
Comment 8 David Green CLA 2008-10-02 23:57:19 EDT
I've made some minor changes to the online User Guide of Mylyn as follows:

> * In the user guide source there is a comment that starts with @<!---@ and ends
> with @--->@: these should be modified as follows: @<!--@ and @-->@ (one less
> '-')

fixed

> * Some lines in the user guide start with a single space.  According to the
> MediaWiki documentation this indicates preformatted text.

fixed

also in several areas <code> tags were present before preformatted text, which resulted in malformed XML as follows

bc.. 
<p>
  <code>
</p>
<pre>
...
</pre>
<p>
  </code>
</p>

p. removed these <code> tags.

Also updated build-helper.xml to validate generated eclipse help (HTML ) content to verify that it's all well-formed XML, so that we don't see runtime errors when viewing the help (Eclipse parses these files at runtime)
Comment 9 David Green CLA 2008-10-02 23:57:46 EDT
Created attachment 114154 [details]
mylyn/context/zip
Comment 10 Steffen Pingel CLA 2008-10-03 00:22:39 EDT
Excellent! We still have to review the contents before putting it into the distribution (bug 246387).
Comment 11 David Green CLA 2008-10-03 09:07:18 EDT
(In reply to comment #10)
> We still have to review the contents before putting it into the distribution (bug 246387).

hmm... this seems contrary to Mik's instructions:

(In reply to comment #3)
> David: Please go ahead and add this as you see fit.

do we really have to wait?
Comment 12 David Green CLA 2008-10-07 15:29:16 EDT
(In reply to comment #6)
> We can standardize on a single convention for linking (e.g. [[Mylyn/FAQ]]) if that helps

I've taken a look and [[Mylyn/FAQ]] looks to be the best option for WikiText.  It will make it easy to detect links that are in a specific space in the wiki.
Comment 13 David Green CLA 2008-10-07 16:00:59 EDT
(In reply to comment #6)
> We can standardize on a single convention for linking (e.g. [[Mylyn/FAQ]]) if that helps

Updated all Mylyn internal wiki links to use the [[Mylyn/Page_Name]] convention.  Tested these links, looks good.  Generated Eclipse help content now resolves these links correctly.
Comment 14 Steffen Pingel CLA 2008-10-14 22:55:18 EDT
(In reply to comment #11)
> (In reply to comment #10)
> > We still have to review the contents before putting it into the distribution
> (bug 246387).
> 
> hmm... this seems contrary to Mik's instructions:
> 
> (In reply to comment #3)
> > David: Please go ahead and add this as you see fit.
> 
> do we really have to wait?

Sorry, I missed that comment. To clarify, I was just referring to the Mylyn user guide. I think we should take at least one pass through the contents to make sure the guide does not contain false information before redistributing it as part of the Mylyn help plug-in.

Mik, are you okay with committing the current state of the Mylyn user guide to cvs?
Comment 15 David Green CLA 2008-10-14 23:23:23 EDT
(In reply to comment #14)
> I think we should take at least one pass through the contents to make
> sure the guide does not contain false information before redistributing it as
> part of the Mylyn help plug-in.

I see your point, but we should also consider that users still have access to that content.  In fact, they're pointed to it from the current Mylyn help plug-in.
Comment 16 David Green CLA 2008-12-04 14:31:38 EST
nothing left to do here.