Bug 237928 - [PropertiesView] Project Explorer issue with Tabbed Properties View
Summary: [PropertiesView] Project Explorer issue with Tabbed Properties View
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-20 09:55 EDT by Karen Butzke CLA
Modified: 2019-09-06 15:31 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2008-06-20 09:55:02 EDT
Currently the Project Explorer view is using the Tabbed Properties framework for the Properties view.  If you single click on a java file in the Project Explorer, the Tabbed Properties version of the Properties view appears.  When you double click the regular version of the Properties view appears.  This makes things look inconsistent.

I am unsure of the proper solution to this bug, potentially the Java editor needs to implement the tabbed properties as well.  I would assume that is the problem, since double clicking moves the focus from the Project Explorer to the Java Editor.  What are the thoughts on pushing the Tabbed Properties view to more areas in the platform?
Comment 1 Eric Moffatt CLA 2008-06-20 15:35:16 EDT
Karen, now that's a good question! Good pickup.

I'll shop this around a bit before assigning it...;-).
Comment 2 Karen Butzke CLA 2008-06-20 15:46:52 EDT
Just to give a little context, I found this because of some other bugs I have been attempting to get fixed.  The related bugs are bug 154781 and bug 158607
Comment 3 Eric Moffatt CLA 2008-06-23 15:08:29 EDT
Note that you can get the same effect by selecting an element in the Project Explorer (tabbed) and in the Package Explorer (non-tabbed). I think that while we might be able to get the JDT folks to adopt the tabbed style it's unlikely we can force everybody to change...

I'll take this to see if there's any way I can make the 'default' PropertySheetPage use the same (or similar) tabbed property page.
Comment 4 Anthony Hunter CLA 2008-07-04 16:52:59 EDT
Eric, was you have guessed, this is a JDT issue since the Package Explorer and the Java editor are not using the tabbed properties view.
Comment 5 Eric Moffatt CLA 2008-07-07 15:58:18 EDT
Yes, I may have to fall back on trying to get the JDT folks involved if I can't adopt the tabbed version as the general PropertySheetPage implementation.

Anthony, how would I over-ride the tab's label. Someone has pointed out that in these cases using "Advanced" (when there's only one tab) is odd. I'd like to change it to either "Info" or perhaps "General". I realize that in cases where there is an actual tab structure that "Advanced" is correct...
Comment 6 Anthony Hunter CLA 2008-07-07 16:27:42 EDT
(In reply to comment #5)
> Anthony, how would I over-ride the tab's label. Someone has pointed out that in
> these cases using "Advanced" (when there's only one tab) is odd. I'd like to
> change it to either "Info" or perhaps "General". I realize that in cases where
> there is an actual tab structure that "Advanced" is correct...

The Advanced tab comes from GMF, but is now used in many places:

Advanced was originally intended to mirror the "advanced" properties in the "old" table format in the original properties view. In the table, there was a show advanced properties button, that would show "all" the properties.

Now with the tabbed properties view, when something is selected, you show a bunch of tabs with interesting UI to modify the properties of the selection.

The Advanced tab is shown as a final tab with the raw properties in a table format. This would be "all" the properties, essentially the "old" table format with the virtual advanced button selected. 

So changing the name "Advanced" in this case will cause confusion with those editors making use of the tabbed properties view properly.

In the case where we have one tab and no adoption of the tabbed properties view, we may want to look at implementing Bug 175057
	



Comment 7 Eric Moffatt CLA 2008-07-08 16:12:52 EDT
Actually that bug is sort of the inverse of what I'm trying to do...;-), I'm trying to -add- a tab onto the default PS.

I'd like to take the 'default' property sheet (i.e. for those folks who don't even know that tabbed properties exist but who provide a PropertySource) that uses the tabbed property 'look'. Once done there would be no way (except 'custom' property page providers) to get a 'non-tabbed' property sheet.

Currently the 'Advanced' tab has the implementation I want/need (i.e. a legacy PS inside a tab), just that in this case the label would be confusing.
Comment 8 Anthony Hunter CLA 2008-07-08 16:36:11 EDT
ok, so you want to reuse the "Advanced" tab concept in another view/editor which provides a PropertySource.

Simply take the org.eclipse.ui.navigator.resources plugin.xml and grab the three extensions propertyContributor, propertyTab and propertySection from the ProjectExplorer. Change the ids and change the name in the propertyTab extension to something else.
Comment 9 Eric Moffatt CLA 2008-07-14 13:21:29 EDT
Beauty, thanks Anthony...
Comment 10 Eric Moffatt CLA 2009-03-05 14:20:31 EST
Moving to triage...
Comment 11 Eric Moffatt CLA 2009-03-05 14:21:25 EST
Changing to 'enhancement' since this is a cosmetic change only...
Comment 12 Eclipse Webmaster CLA 2019-09-06 15:31:53 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.