Description Randy Giffen 2001-10-10 22:35:10 EDT

1. The following are being done in 
org.eclipse.jface.examples.wizards.ClassCreationWizard.addPages()
	setNeedsProgressMonitor(true);
	setWindowTitle("Class Creation Wizard");
It would be better style to do these in the constructor.

2. Why do you have the following check in:
org.eclipse.jface.examples.wizards.ClassCreationWizard.performFinish()
		String classname= classNamePage.getClassName();
		if (classname.length() == 0)
			return false;
Wouldn't the enablement code prevent this?

3. The comment in 
org.eclipse.jface.examples.wizards.ClassCreationWizard.addPages() is:
/**
 * Hook method for lazy page creation. Subclasses should reimplement
 * this method if they want to create their pages just before the
 * wizard becomes visible.
 */
Adding has nothing to do with creating the page controls if that is what you mean.
Suggest
/**
 * Adds this wizard's pages.
 */

4. Replace org.eclipse.jface.examples.wizards.ClassNamePage.enter(int) with
public void setVisible(boolean visible) {
	super.setVisible(visible);
	if (visible)
		text.setFocus();
}

5. org.eclipse.jface.examples.wizards.MethodStubPage.dispose()
Saving of dialog settings should be called from the Wizards perform finish method.
Settings should only be saved if finish is a success.

6. Typo in comment of
org.eclipse.jface.examples.wizards.SuperClassAndInterfacePage.createControl(Composite)
Creates the paeg's UI component.

NOTES: