Bug 237294 - [results] Performance test not grey from degredation comment
Summary: [results] Performance test not grey from degredation comment
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, test
Depends on:
Blocks:
 
Reported: 2008-06-16 11:17 EDT by Darin Wright CLA
Modified: 2008-09-22 12:46 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (3.45 KB, patch)
2008-06-17 10:14 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2008-06-16 11:17:35 EDT 
I20080613-2000

The JDT debug 'remove breakpoint' perfomance test has set a degradation comment, but the test still appears as red instead of grey. 

Fredieric thinks this is because the test is in the 3.3 fingerprint, but is has been removed from the fingerprint in 3.4.
Comment 1 Frederic Fusier CLA 2008-06-16 11:33:53 EDT 
I'll try to verify this assumption while generating the results locally...
Comment 2 Frederic Fusier CLA 2008-06-17 10:14:11 EDT 
Created attachment 105166 [details]
Proposed patch
Comment 3 Frederic Fusier CLA 2008-06-17 10:19:28 EDT 
My assumption was correct, as a summary was got from the baseline that prevented to look at comments from the builds. The method internalQueryScenarioSummaries of DB_Results wrongly assumed that baseline and builds have both summaries or they both have not...

I need to know if we decide to put this in 3.4 or leave with it and wait 3.5 to fix it...
Comment 4 Frederic Fusier CLA 2008-09-22 12:46:08 EDT 
Patch released in HEAD. I verified it works while generating M20080910-1030 results. At that time, it was not possible to verify this on M20080911-1700 (aka 3.4.1), results because no failure was logged in the database, hence all results get the OK icon :-(