Bug 236597 - Include commit set details in patch files
Summary: Include commit set details in patch files
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-06-11 06:46 EDT by Brock Janiczak CLA
Modified: 2019-09-06 16:12 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brock Janiczak CLA 2008-06-11 06:46:04 EDT
When you create a patch from a commit set in the sync view, the commit set details (most notably, the commit comment) are not stored in the patch file.  It might help the person applying the patch if the commit set were automatically recreated when the patch was applied using some extra information stored in the patch file.  It would certainly make reviewing multiple patches at once a bit easier and you would have a head start, as the commit comment would already be there for you.

My idea is to store the commit set details in the header section of the patch as a comment.  It would be possible to store multiple commit sets in the patch and link the file changes to the commit set defined in the header, but this could be added later.

Let me know if you are interested in this feature and i will try to implement it.

I don't think this could be implemented at the team level as it needs access to the provider specific changeset manager.
Comment 1 Michael Valenta CLA 2008-06-11 07:34:49 EDT
The complicating factor here is that the Apply Patch wizard in Eclipse is provided by the Compare plug-in which knows nothing about commit sets. So, while it would be fairly straightforward to add an additional header line, we don't have anything in place that would allow CVS to interpret it when the patch was applied.
Comment 2 Tomasz Zarna CLA 2008-06-11 08:01:26 EDT
(In reply to comment #1)

True, but I agree with Brock that a patch comment would be useful. You could start with displaying it while applying the patch. I know it's not exactly what you want to achieve, but I guess it would be a good start.

Comment 3 Szymon Brandys CLA 2008-06-11 08:29:04 EDT
(In reply to comment #2)
> (In reply to comment #1)
> 
> True, but I agree with Brock that a patch comment would be useful.

What I usually do is using the patch file name to keep such information. However I agree with Tomasz.

Would we be able to create a change set using this information?

Comment 4 Michael Valenta CLA 2008-06-11 09:09:45 EDT
The Compare plug-in cannot create a change set because it is below team in the architecture (i.e. Team depends on Compare). The best approach to solving this that I can see is to somehow allow repository providers to override the Apply Patch action when the selection contains projects mapped to the repository provider. Perhaps we can use the new Commands story to accomplish this properly. Then, you could write a CVS specific Apply Patch wizard that has all the knowledge required to parse the additional header info and create a change set.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:12:49 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.