Community
Participate
Working Groups
This is to track some follow-through work that started with bug 231453. To summarize, historically we purposely used plugins only in our "feature dependencies" but due to improvements in P2 software updates (where it purposely minimizes downloads and installs) this is no longer always the right thing to do. The goal (the problem to overcome) is that we want the same stuff installed, whether someone unzips everything, uses the EPP JEE Package, or, in this case, picks "Dali" from update site and installs "just" that. For example, I think the way it is now, it would end up installing required XML Code, but not XML Documentation. That might be desired in the future! But, the problem for now is that it will be impossible to take advantage of "patch maintenance" if we don't know exactly what features are installed in all these scenarios. I hope to attach patch here later today. For "final" RC4 build on Tuesday.
Created attachment 104259 [details] patch to 'require' features instead of plugins This is my initial best guess at what the minimal, smallest required features should be. Probably need to do a head build, and/or some testing before claiming it's done.
Patch checked into head. David let me know when DTP reference will be ready, and I will try a local build.
I have updated the DTP reference to the latest available for download, dtp-sdk-1.6RC4-200806090500.zip
The patch is passing in the local build. There is nothing abnormal to report.
Since this is merely an "extension" of bug 231453 I'm marking as PMC approved, to correspond to bug 231453. Thanks,
Released.
David, I missed this originally, but now notice that you removed the DTP Enablement feature from the requires list. This is not a "required to function" feature, but is something that we were including for usability purposes. (see bug 192269). I imagine you might have done this intentionally given your comments, so I wanted understand the motivation behind this, or whether you were just trying to get things to work at a minimum and waiting for us to add back "wanted" features.
(In reply to comment #7) > David, > > I missed this originally, but now notice that you removed the DTP Enablement > feature from the requires list. This is not a "required to function" feature, > but is something that we were including for usability purposes. (see bug > 192269). > > I imagine you might have done this intentionally given your comments, so I > wanted understand the motivation behind this, or whether you were just trying > to get things to work at a minimum and waiting for us to add back "wanted" > features. > Definitely the later ... I just looked at what would minimally be required, and figured you all would adjust if something else was desired.
re-opening. Normally I say since "mere usability" it would not be worth a respin, but if we fix bug 237668, we _might_ also want to fix this, since it is a regression introduced with recent change. (can't say I really understand the impact ... but sounds like things are not 'usable' without installing more from DTP). Also ... I notice the features in the require section are over specified .. many have 4 version field, instead of 3.
Change released.
Given that this change was released before the maintenance branch was created, I'm concerned about the impact this change could have on a user updating their 2.0 code. I assume that new installer could handle the additional dependencies when updating, but I'm not sure that this is the case. I was originally thinking we would make this change in Head after we branched for maintenance to be on the safe side.
(In reply to comment #11) Fine with me. It probably would work ok, but not sure it's worth the effort. See also bug 238280. We will fix some of the DTP documentation issues in the JEE IDE in maintenance release, so that should help many users.
Entered bug 242118 to address this lingering issue.
Minor housekeeping - This last issue was address in 2.1M1.
