Bug 192269 - Dali install from the Update Manager does not run after auto prereq selection
Summary: Dali install from the Update Manager does not run after auto prereq selection
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: Tran Le CLA
QA Contact:
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-12 15:11 EDT by Neil Hauge CLA
Modified: 2007-09-10 13:53 EDT (History)
3 users (show)

See Also:
jlanuti: pmc_approved? (jgarms)
david_williams: pmc_approved+
jlanuti: pmc_approved? (raghunathan.srinivasan)
jlanuti: pmc_approved? (naci.dai)
deboer: pmc_approved+
jlanuti: pmc_approved? (neil.hauge)

Attachments
Replaced required DTP plugins by features (1.08 KB, patch)
2007-06-12 18:03 EDT, Tran Le CLA 		no flags Details | Diff
DTP features + user doc plugins (1.19 KB, patch)
2007-06-12 18:29 EDT, Tran Le CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Hauge CLA 2007-06-12 15:11:30 EDT 
After installing Dali from the Europa Discovery update site I was unable to perform any Dali related operations.  In the update manager, Dali was selected, along with the Select Required... plugins.  What was delivered and installed was not enough to run Dali, as the jpt plugins were in the [Installed] state, and not resolved, starting, or active.

After looking around, I noticed that the DTP was not configured for relational data sources.  Only flat-file ODA data source options were available in the Data Source Explorer.  All of our required plug-ins for compile were installed, but they could not be resolved.

The following features were added manually (via update manager) to fully resolve the Dali plugins.

org.eclipse.datatools.doc.user_1.5.0.200705301
org.eclipse.datatools.doc.user_1.5.0.200705301
org.eclipse.datatools.enablement.apache.derby.feature_1.5.0.200705301
org.eclipse.datatools.enablement.apache.derby.feature_1.5.0.200705301
org.eclipse.datatools.enablement.feature_1.5.0.200705301
org.eclipse.datatools.enablement.hsqldb.feature_1.5.0.200705301
org.eclipse.datatools.enablement.ibm.feature_1.5.0.200705301
org.eclipse.datatools.enablement.jdbc.feature_1.5.0.200705301
org.eclipse.datatools.enablement.msft.feature_1.5.0.200705301
org.eclipse.datatools.enablement.mysql.feature_1.5.0.200705301
org.eclipse.datatools.enablement.oda.feature_1.5.0.200705301
org.eclipse.datatools.enablement.oda.designer.feature_1.5.0.200705301
org.eclipse.datatools.enablement.oracle.feature_1.5.0.200705301
org.eclipse.datatools.enablement.postgresql.feature_1.5.0.200705301
org.eclipse.datatools.enablement.sybase.feature_1.5.0.200705301
org.eclipse.datatools.enablement.feature_1.5.0.200705301
org.eclipse.datatools.enablement.hsqldb.feature_1.5.0.200705301
org.eclipse.datatools.enablement.ibm.feature_1.5.0.200705301
org.eclipse.datatools.enablement.jdbc.feature_1.5.0.200705301
org.eclipse.datatools.enablement.jdt.feature_1.5.0.200705301
org.eclipse.datatools.enablement.jdt.feature_1.5.0.200705301
org.eclipse.datatools.enablement.msft.feature_1.5.0.200705301
org.eclipse.datatools.enablement.mysql.feature_1.5.0.200705301
org.eclipse.datatools.enablement.oda.designer.feature_1.5.0.200705301
org.eclipse.datatools.enablement.oda.feature_1.5.0.200705301
org.eclipse.datatools.enablement.oracle.feature_1.5.0.200705301
org.eclipse.datatools.enablement.postgresql.feature_1.5.0.200705301
org.eclipse.datatools.enablement.sybase.feature_1.5.0.200705301
org.eclipse.datatools.intro_1.5.0.200705301
org.eclipse.datatools.intro_1.5.0.200705301

It probably make sense to install all of DTP for Dali, since the user will likely want all of DTP, but it seems that the update manager should have picked up required plugins of our required plugins, but I'm not clear on how this is supposed to work.
Comment 1 John Graham CLA 2007-06-12 15:32:29 EDT 
Not sure how the Dali features are written, but you could set <requires><import/></requires> or <includes/> on the following DTP features:

org.eclipse.datatools.connectivity.feature
org.eclipse.datatools.modelbase.feature
org.eclipse.datatools.sqldevtools.feature
org.eclipse.datatools.enablement.feature

If you want user doc in addition, you can add:

org.eclipse.datatools.intro
org.eclipse.datatools.doc.user

This will give you an "end user" type of install. If you want the DTP src and isv documentation, then the SDK wrapper feature is the way to go. In this case, you'll want:

org.eclipse.datatools.sdk.feature
org.eclipse.datatools.enablement.feature

and then the user doc, if required.
Comment 2 Neil Hauge CLA 2007-06-12 16:00:52 EDT 
Our current requires list can be found on bug 190354.
Comment 3 John Graham CLA 2007-06-12 16:13:56 EDT 
I notice that the requires list in 190354 picks certain DTP plug-ins about specifically. I guess in theory this could cause a transitive closure on dependencies for those plug-ins, but I don't think it does. I seem to remember some discussion on the cross-project mailing list about this type of usage not working.

Anyway, I'd suggest that you require the features rather than specific plug-ins, as this is known to work correctly.
Comment 4 Tran Le CLA 2007-06-12 18:03:43 EDT 
Created attachment 71094 [details]
Replaced required DTP plugins by features
Comment 5 Tran Le CLA 2007-06-12 18:29:20 EDT 
Created attachment 71096 [details]
DTP features + user doc plugins
Comment 6 Neil Hauge CLA 2007-06-12 19:47:07 EDT 
This is a patch to fix the problem that the Dali JPA Tools do not work when installed via the Update Manager.  We believe the changes suggested by John will fix the problem, but won't know for sure until they can be tested via the update manager.  Since we don't work at all right now out of the box, this patch cannot make that experience worse.  It is also worth mentioning that the DTP components pulled by JST will probably not work either, but I'm not 100% sure about this.  I suppose that is another bug.

Patch reviewed and approved.  Requesting PMC approval and any other advice they can offer.
Comment 7 David Williams CLA 2007-06-13 12:11:35 EDT 
I am concerned about this for a couple of reasons, mostly because it seems like no one knows why this isn't working, so worry were are just working around some unknown issue. It _might_ be related to DTP having many optional relationships? 
If true, then suspect the "compute" button in PDE doesn't work well in that case? 

But I approve if and only if JPA team agrees with John that end users would want all of DTP installed if they want to use JPA. I don't have an intuitive sense if it's just "almost all users would want it all" (which justifies using feature level pre-reqs) or if "a number of users would want it all" (which might not justify it). 

Also, it _can_ be tested, though I admit it's not easy. You basically have to "duplicate" the Europa staging area on your local machine, then swap in the features/plugins you want to change. While not easy, you may want to set aside some time to figure out how to do this since I suspect this won't be the last update issue :)
Comment 8 Neil Hauge CLA 2007-06-13 13:03:00 EDT 
I *think* this problem is probably related to a computed dependency problem. 
There are two ways to work around that problem for now, one being to list the
additional plugins needed to run (although this is trial and error, and could
be wrong in the future since it is not based on computed dependencies), and
two, to use the feature level pre-reqs (this seems like the safer route). 
After some more consideration, it seems that for our purposes, the feature
level pre-reqs are the way to go.  We already require 80% of DTP, with the last
20% or so being the Enablement feature.  I think that most Dali users are going
to want DB specific support out of the box when installing Dali.  To not
provide this could be a usability issue, in that users would download and then
wonder why there isn't more detailed connection configuration support, or why
the stored procedures aren't showing up in their DS Explorer.

I think the feature level choice makes sense for most Dali users.
Comment 9 Tran Le CLA 2007-06-13 14:40:06 EDT 
Patch applied and released.