Bug 236169 - Use Synchronize View for Apply Patch
Summary: Use Synchronize View for Apply Patch
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL: http://wiki.eclipse.org/Apply_patch_i...
Whiteboard:
Keywords:
Depends on: 298923 300215 300222
Blocks: 288561
  Show dependency tree
 
Reported: 2008-06-07 02:44 EDT by Will Hains CLA
Modified: 2010-03-05 07:31 EST (History)
5 users (show)

See Also:

Attachments
3.6M4 work in o.e.compare (5.70 KB, patch)
2009-12-15 08:56 EST, Tomasz Zarna CLA 		no flags Details | Diff
3.6M4 work in o.e.team.ui (70.68 KB, patch)
2009-12-15 08:58 EST, Tomasz Zarna CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Will Hains CLA 2008-06-07 02:44:21 EDT 
Current behaviour: "Apply Patch" opens a wizard dialog to go through the steps of applying a patch.

Desired behaviour: "Apply Patch" uses the Synchronize View, so that while the comparison is being done, other features of Eclipse are available to use.
Comment 1 Tomasz Zarna CLA 2008-06-17 11:49:47 EDT 
Michael Valenta wrote in bug 189178, comment 4:

" (...) it is possible but not trivial (i.e. the dialog has a
fixed life span whereas the Synchronize view entry could stick around for quite
a while and would need to react to local changes). (...)"
Comment 2 Markus Keller CLA 2009-05-25 08:04:45 EDT 
See also bug 86345 and bug 117298 for related requests.
Comment 3 Tomasz Zarna CLA 2009-12-03 08:35:01 EST 
Current work progress, issues faced and tasks to be fixed are tracked on http://wiki.eclipse.org/Apply_patch_in_Sync_view. I'll be updating the page frequently, but it's not 100% done yet (I haven't described the suggested solution in details neither I have listed up all the issues). Comments are welcome, as always.
Comment 4 Tomasz Zarna CLA 2009-12-15 08:56:50 EST 
Created attachment 154469 [details]
3.6M4 work in o.e.compare
Comment 5 Tomasz Zarna CLA 2009-12-15 08:58:15 EST 
Created attachment 154471 [details]
3.6M4 work in o.e.team.ui
Comment 6 Tomasz Zarna CLA 2009-12-15 09:09:51 EST 
Both patches have been committed to "branch_20091215_bug236169" branch created for o.e.compare and o.e.team.ui. During 3.6M5 I will continue to work on the branch and merge back to HEAD when most of the issues listed on the wiki[1] get fixed.

[1] http://wiki.eclipse.org/Apply_patch_in_Sync_view
Comment 7 Tomasz Zarna CLA 2010-01-25 12:29:38 EST 
We're moving this bug to 3.6M6, but still want to fix bug 298923 in M5 i.e. we would like to merge the changes from the dev branch asap.
Comment 8 Tomasz Zarna CLA 2010-03-05 07:31:11 EST 
All blockers have been fixed, so I'm marking this one as "FIXED" as well. Thanks for your help Pawel! We will now focus on bug 300345.