Bug 235860 - could not open the editor
Summary: could not open the editor
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.0   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 235213 244016 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-06-05 11:52 EDT by Tomasz Zarna CLA
Modified: 2009-07-23 16:49 EDT (History)
3 users (show)

See Also:


Attachments
fix (1.15 KB, patch)
2008-06-14 03:40 EDT, Steffen Pingel CLA
no flags Details | Diff
mylyn/context/zip (2.12 KB, application/octet-stream)
2008-06-14 03:40 EDT, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2008-06-05 11:52:54 EDT
Version: working on plug-ins exported today (2008-06-05)

I was forced to do a restart while having an activated task. This is what I got instead of the task editor after the restart:

Unable to create editor ID org.eclipse.mylyn.tasks.ui.editors.task: Factory org.eclipse.mylyn.tasks.ui.elementFactories.task.editor returned null from createElement for editor id=org.eclipse.mylyn.tasks.ui.editors.task name=235653: User doc needs updating: CVS password management

org.eclipse.ui.PartInitException: Factory org.eclipse.mylyn.tasks.ui.elementFactories.task.editor returned null from createElement for editor id=org.eclipse.mylyn.tasks.ui.editors.task name=235653: User doc needs updating: CVS password management
	at org.eclipse.ui.internal.EditorReference.getRestoredInput(EditorReference.java:367)
	at org.eclipse.ui.internal.EditorReference.getEditorInput(EditorReference.java:328)
	at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:591)
	at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:428)
	at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:594)
	at org.eclipse.ui.internal.EditorReference.getEditor(EditorReference.java:266)
	at org.eclipse.ui.internal.WorkbenchPage.makeActiveEditor(WorkbenchPage.java:1246)
	at org.eclipse.ui.internal.WorkbenchPage.updateActivePart(WorkbenchPage.java:1204)
	at org.eclipse.ui.internal.WorkbenchPage.handleDeferredEvents(WorkbenchPage.java:1384)
	at org.eclipse.ui.internal.WorkbenchPage.deferUpdates(WorkbenchPage.java:1373)
	at org.eclipse.ui.internal.WorkbenchPage.access$14(WorkbenchPage.java:1364)
	at org.eclipse.ui.internal.WorkbenchPage$15.runWithException(WorkbenchPage.java:3261)
	at org.eclipse.ui.internal.StartupThreading$StartupRunnable.run(StartupThreading.java:31)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3798)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3423)
	at org.eclipse.ui.application.WorkbenchAdvisor.openWindows(WorkbenchAdvisor.java:803)
	at org.eclipse.ui.internal.Workbench$27.runWithException(Workbench.java:1361)
	at org.eclipse.ui.internal.StartupThreading$StartupRunnable.run(StartupThreading.java:31)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3798)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3423)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2293)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2198)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:493)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:488)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:112)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:382)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1236)
Comment 1 Tomasz Zarna CLA 2008-06-05 11:55:37 EDT
What makes me sad is that after I managed to open and activated the task I realized that the context got lost.
Comment 2 Steffen Pingel CLA 2008-06-05 18:38:38 EDT
Sorry about that. Contexts are currently only saved on task deactivation. Implementing more frequent saving of contexts is tracked on bug 219173.

*** This bug has been marked as a duplicate of bug 219173 ***
Comment 3 Tomasz Zarna CLA 2008-06-11 05:29:25 EDT
And what about the PartInitException from comment 0? This doesn't look good either, and I've just got it again working with Mylyn built this morning.
Comment 4 Steffen Pingel CLA 2008-06-11 15:36:29 EDT
Reopening to investigate exception.
Comment 5 Steffen Pingel CLA 2008-06-11 15:38:53 EDT
Tomasz, do you know if the editor that failed to restore was opened from a search result or hyperlink, meaning it was a task that was not in your task list? 

Rob, we probably need to a add a check to only save tasks from the task list to the memento.
Comment 6 Steffen Pingel CLA 2008-06-12 21:38:57 EDT
It's getting to late for 3.0 to get this fixed. Need to defer to the next maintenance release.
Comment 7 Tomasz Zarna CLA 2008-06-13 04:08:25 EDT
(In reply to comment #5)
> Tomasz, do you know if the editor that failed to restore was opened from a
> search result or hyperlink, meaning it was a task that was not in your task
> list? 

Sorry, I didn't pay much attention to this, don't remember. I will let you know as soon as I see it again.

Comment 8 Steffen Pingel CLA 2008-06-13 04:28:02 EDT
*** Bug 235213 has been marked as a duplicate of this bug. ***
Comment 9 Steffen Pingel CLA 2008-06-14 03:40:48 EDT
Created attachment 104952 [details]
fix
Comment 10 Steffen Pingel CLA 2008-06-14 03:40:49 EDT
Created attachment 104953 [details]
mylyn/context/zip
Comment 11 Steffen Pingel CLA 2008-06-14 03:41:14 EDT
Tasks that are not in the task list are not restored on restart in >3.0.0.I20080614-0400. Mik, please review.
Comment 12 Steffen Pingel CLA 2009-07-23 16:49:47 EDT
*** Bug 244016 has been marked as a duplicate of this bug. ***