Community
Participate
Working Groups
Since we started to use Secure Storage for managing CVS passwords[1] it seems reasonable to replace "Password Management" preference page[2] with the one introduced by Secure Storage[3]. [1] bug 222124 [2] Team > CVS > Password Management [3] General > Security > Secure Storage, Contents tab, CVS node
You're right, this page doesn't seem to serve any purpose anymore. Its probably good to teach people to go to the general Security page to do password management. The risk of keeping the CVS page is that it may obscure the storage model (ie. who stores them and how). Also since the CVS passwords are now more strongly stored, its less likely they'll want to delete them.
All true except that ability to "manage" individual entries in the secure storage was removed for 3.4 due to reactions like "I do not understand what it is for, delete it".
(In reply to comment #2) > All true except that ability to "manage" individual entries in the secure > storage was removed for 3.4 due to reactions like "I do not understand what it > is for, delete it". I refer here to the secure storage view and context menus on it to add/remove nodes and values.
(In reply to comment #1) > You're right, this page doesn't seem to serve any purpose anymore. > > Its probably good to teach people to go to the general Security page to do > password management. The risk of keeping the CVS page is that it may obscure > the storage model (ie. who stores them and how). Also since the CVS passwords > are now more strongly stored, its less likely they'll want to delete them. Kevin, you're UI/Usability guru, should I simple remove the page or make it blank with only a link to Secure Storage remaining (+ some comment)?
(In reply to comment #4) > (In reply to comment #1) > > You're right, this page doesn't seem to serve any purpose anymore. > > > > Its probably good to teach people to go to the general Security page to do > > password management. The risk of keeping the CVS page is that it may obscure > > the storage model (ie. who stores them and how). Also since the CVS passwords > > are now more strongly stored, its less likely they'll want to delete them. > > Kevin, you're UI/Usability guru, should I simple remove the page or make it > blank with only a link to Secure Storage remaining (+ some comment)? I'd suggest remove the page. Question though: what happens if someone tries to keep their 3.3 workspace and opens it in 3.4? Do we move their CVS pass to secure store, or continue to retrieve it from the 3.3 store? Either way, in the New CVS Repo wizard (and the stand alone password prompt), suggest we have a link pointing to the pref page with some text like "If you later want to manage your password, please see the Secure Storage preference page". This would work well with the fact that you already say that password entry will trigger secure storage. That way you train them the right new place to go so don't so much need old page with link to new place.
(In reply to comment #5) > Question though: what happens if someone tries to keep their 3.3 workspace and > opens it in 3.4? Do we move their CVS pass to secure store, or continue to > retrieve it from the 3.3 store? Haven't done it, but I'm pretty sure that the user will be asked to reenter all his/her passwords. Currently, CVS passwords are not migrated to secure storage. See bug 227517. > Either way, in the New CVS Repo wizard (and the stand alone password prompt), > suggest we have a link pointing to the pref page with some text like "If you > later want to manage your password, please see the Secure Storage preference > page". This would work well with the fact that you already say that password > entry will trigger secure storage. That way you train them the right new place > to go so don't so much need old page with link to new place. Sounds good.
Created attachment 112676 [details] Patch v01 Patch that comments out the old "Password managment" page and removes a reference to this page in User Documentation. Things to consider: * deleting PasswordManagmentPreferencePage * deleting ref-19cvs-password.htm help page * removing (instead of commenting out) extension for the pref page
Created attachment 112677 [details] mylyn/context/zip
* a link pointing to the new preference page as suggested by Kevin in comment 5
Created attachment 113113 [details] Patch v02
Szymon could you check if the fix is ok with you? I wanted to release it asap, but I remember you had some questions about the it...
There are still some entries appearing in the to-be-removed Password Management page. I would expect the page to have no entries (except those added before we moved to Secure Storage), but as soon as I create a new Repo Location (with a password) it does appear in both the old pass page and the one in Secure Store section. Before we decide to finally remove the old page we should investigate why these entries still appear on the page.
Sorry, I haven't managed to investigate it in 3.5M5, hopefully Pawel will find some time for it during 3.5M6.
(In reply to comment #12) > There are still some entries appearing in the to-be-removed Password Management > page. I would expect the page to have no entries (except those added before we > moved to Secure Storage), but as soon as I create a new Repo Location (with a > password) it does appear in both the old pass page and the one in Secure Store > section. Before we decide to finally remove the old page we should investigate > why these entries still appear on the page. > This is not a problem since the page to be deleted calls CVSRepositoryLocation.getCVSNode() to populate the UI and this method was changed along with the fix for bug 222124 to get data from Secure Storage. In other words information from secure storage is duplicated on both preference pages now.
Created attachment 125214 [details] Patch v03 Updated patch.
Created attachment 125215 [details] Patch v04 Updated copyright dates and removed keyword extension for the removed pref page.
Fixed in HEAD, but filed bug 264318. Available, or I should rather say not available, starting from build I20090210-0800.
