Bug 235163 - Output directory not set correctly in Web facet install
Summary: Output directory not set correctly in Web facet install
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P1 major (vote)
Target Milestone: 3.0 RC4   Edit
Assignee: Neeraj Agrawal CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-06-02 11:35 EDT by Neeraj Agrawal CLA
Modified: 2008-08-01 02:23 EDT (History)
5 users (show)

See Also:
david_williams: pmc_approved+
cbridgha: pmc_approved? (raghunathan.srinivasan)
cbridgha: pmc_approved? (naci.dai)
cbridgha: pmc_approved? (deboer)
neil.hauge: pmc_approved+
kaloyan: pmc_approved+
cbridgha: review+

Attachments
Propsed fix (1.55 KB, patch)
2008-06-02 11:36 EDT, Neeraj Agrawal CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neeraj Agrawal CLA 2008-06-02 11:35:17 EDT 
Build ID: RC2

Steps To Reproduce:
1. Create a Dynamic Web project, choose Web content directory something other than "WebContent"

2. On project creation, the non default name is used as the default output folder( and the project explorer preferences is filtering out the default output folders, so the non default folder is not displayed in the tree.), this is bug, the name should be appended with  "WEB-INF/classes"





More information:
Comment 1 Neeraj Agrawal CLA 2008-06-02 11:36:40 EDT 
Created attachment 103145 [details]
Propsed fix

The problem is fixed by adding WEB-INF/classes to the folder name
Comment 2 Chuck Bridgham CLA 2008-06-03 10:27:39 EDT 
Changing the description...

If the "useSingleRoot" is set to true, and a non-default value is specified for the content folder name, the output directory isn't set to <new content name>/WEB-INF/classes  - as it was in the past - this is a regression.

I approve this fix, and it is essential to the adopter release.

I have tested in WTP and adopter scenarios, and both work well with this patch.
(This patch doesn't affect the "default" scenario in the WTP case.)
Comment 3 Kaloyan Raev CLA 2008-06-03 10:30:50 EDT 
Approved. Simple fix for important issue.
Comment 4 David Williams CLA 2008-06-03 18:18:39 EDT 
kind of amazes me this type of bug was never reported before ... is it related to some other fix? (but, am in favor of the fix)
Comment 5 Chuck Bridgham CLA 2008-06-04 18:06:34 EDT 
Yep tracked it to bug 219996

In any case - this restores the function
Comment 6 Carl Anderson CLA 2008-06-05 15:19:47 EDT 
Committed to HEAD