Community
Participate
Working Groups
Right now the code that serves as the "bridge" between WTP's Faceted Project Framework and JDT is sprinkled throughout multiple plugins in three different components (common, j2ee and server tools). In particular, this is referring to the jst.java facet and standard.jre runtime component. The goal of this enhancement is to consolidate all of that code in one place. That would make it not only make the code easier to understand, but will also open the door for potentially offering that portion (jdt/facets integration) as a separate distribution.
Created attachment 90498 [details] Changes to server component This patch contains the work to remove code related to standard.jre component from the jst.server.core and jst.server.ui plugins. In addition to applying this change, jst.server.ui/icons/obj16/jre.gif should be deleted (patch can't handle binary files). This patch needs to be paired with patch to the common component that re-introduces this functionality. I will attach that patch next.
Created attachment 90500 [details] Changes to common component This is a matching change to the "Changes to server component" patch. In addition to applying this patch, a jst.common.project.facet.core/images/standard-jre-component.gif file needs to be added. It can be created by copying jst.server.ui/icons/obj16/jre.gif file.
Comment on attachment 90500 [details] Changes to common component marking the second attachment as a patch.
Kosta, I reviewed the code, it looks good. I don't have any concerns as we are just moving code from one place to the other, and the new feature should break any adopter. May I suggest the following changes in the MANIFEST.MF: - Eclipse-LazyStart: true + Bundle-ActivationPolicy: lazy The Eclipse-LazyStart is deprecated so we might as well change it to the new method.
fixing typo on comment #4: ... moving code from one place to the other, and the new feature should[n't] break any adopter. ... (In reply to comment #4) > Kosta, > > I reviewed the code, it looks good. I don't have any concerns as we are just > moving code from one place to the other, and the new feature should break any > adopter. > > May I suggest the following changes in the MANIFEST.MF: > - Eclipse-LazyStart: true > + Bundle-ActivationPolicy: lazy > > The Eclipse-LazyStart is deprecated so we might as well change it to the new > method. >
Sure. Should we update this attribute for all three bundles at the same time?
Yep.
Code checked in and released.
Committed and releasted the changes to the common component as well.
Hmm... I just synced to HEAD. It doesn't look like the changes to jst.server.ui made it in. This is causing some visual glitches in the latest i-build.
It seems that I forgot some files. I am revising this now.
Thanks. Also see my note about the jre.gif file. You will have to manually delete it, since patches don't handle binary files.
Second round of files released to HEAD.
Thanks. I am no longer showing any changes remaining after syncing to HEAD.
All changes related to this enhancement have been completed.
Closing.
New Gerrit change created: https://git.eclipse.org/r/108542
New Gerrit change created: https://git.eclipse.org/r/108546
