Bug 234362 - [Graphics] Update the marker help graphic
Summary: [Graphics] Update the marker help graphic
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC4   Edit
Assignee: Kevin McGuire CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-28 09:45 EDT by Tod Creasey CLA
Modified: 2008-06-04 10:16 EDT (History)
1 user (show)

See Also:
Mike_Wilson: pmc_approved+


Attachments
Image (541 bytes, application/octet-stream)
2008-05-28 09:45 EDT, Tod Creasey CLA
no flags Details
What it looks like in context (102.75 KB, image/jpeg)
2008-06-03 15:19 EDT, Kevin McGuire CLA
no flags Details
Currently looks like (blech!) (93.38 KB, image/jpeg)
2008-06-03 15:24 EDT, Kevin McGuire CLA
no flags Details
Some experimental alternatives (147.81 KB, application/x-zip-compressed)
2008-06-03 18:10 EDT, Kevin McGuire CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2008-05-28 09:45:32 EDT
Created attachment 102362 [details]
Image

With the new version attached
Comment 1 Tod Creasey CLA 2008-05-29 09:29:22 EDT
IIRC Kevin handles the graphics from the design team now
Comment 2 Kevin McGuire CLA 2008-05-29 11:35:23 EDT
Why the change and where did the artwork come from?
Comment 3 Tod Creasey CLA 2008-05-29 13:08:20 EDT
This is a late delivery from the design team. The current icon is a temporary one I added back around M4.
Comment 4 Kevin McGuire CLA 2008-05-30 12:06:48 EDT
Tod, where exactly does this appear?
Comment 5 Tod Creasey CLA 2008-05-30 16:22:19 EDT
In any marker with help. No Eclipse markers have it so you will need to use the example in the org.eclipse repository.
Comment 6 Kevin McGuire CLA 2008-06-03 15:19:01 EDT
Created attachment 103403 [details]
What it looks like in context
Comment 7 Kevin McGuire CLA 2008-06-03 15:24:41 EDT
Created attachment 103406 [details]
Currently looks like (blech!)

Mike, this is just a replacement of a marker decorator icon.

Attached are the screen shots after and before.

The decoration only appears for those markers which have help info.  None of the JDT do, so there is no visible change to the SDK.  However it will look a lot nicer for those using the new marker support and adding help.
Comment 8 Mike Wilson CLA 2008-06-03 16:11:47 EDT
Comparing the screen caps from Kevin, I'm not happy with the look of the new image. In particular, the color language (white on blue) differs from the other places where help icons show up currently in our UI. (It also draws the eye two strongly away from the main icon, particularly when they are stacked vertically as shown in the screen cap.)

Unfortunately, the old icon is illegible, so we're kind of stuck between a rock and hard place for 3.4... Since we don't actually have instances of this being used in the SDK for 3.4, I guess I'm ok with adding it for now.

Please redo for 3.4.1, with an eye to matching existing iconography. 

Apologies to consumers end up needing to redo screenshots for 3.4.1. :-(
Comment 9 Mike Wilson CLA 2008-06-03 16:13:02 EDT
(*sigh*. Man, I'm tired. That would be "too strongly" not "two strongly", of course.)
Comment 10 Kevin McGuire CLA 2008-06-03 18:10:15 EDT
Created attachment 103455 [details]
Some experimental alternatives

Here are two more versions that I did myself.  

V2 has more definition in the ? but the RHS of the circle gets cropped funny (darn if only we had 9x9 overalys!). Not super noticeable though.

V3 has less definition but more balanced looking.

My pref is v3 as a stand-in until we get media to do a new one for 3.4.1.  Its more legible than the original but less obtrusive than the new one.
Comment 11 Mike Wilson CLA 2008-06-04 09:03:04 EDT
Agree that your V3 is a better alternative for now. 
Comment 12 Kevin McGuire CLA 2008-06-04 10:16:23 EDT
Release v3 of the images for I20080604-1800