Bug 234345 - [Viewers] AbstractTreeViewer#getChildren(Widget,Object[]) holds doc that it is experimental
Summary: [Viewers] AbstractTreeViewer#getChildren(Widget,Object[]) holds doc that it i...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2008-05-28 08:05 EDT by Thomas Schindl CLA
Modified: 2008-10-28 16:49 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2008-05-28 08:05:27 EDT 
a) Remove the experimental description => Why do we need this method
b) Remove the method
Comment 1 Boris Bokowski CLA 2008-05-29 17:00:26 EDT 
a) -> no, we don't need the method. It was part of an experiment to optimize performance, see bug 209097. When the changes for that bug caused test failures, they were rolled back incompletely.
b) This would have been a good thing before the API freeze, but we cannot do that anymore.
c) I think the only option we have is to mark the method as deprecated.

Should we do c) for 3.4 or 3.5? I am voting for 3.5...
Comment 2 Remy Suen CLA 2008-05-31 20:58:26 EDT 
What about methods like internalAdd(Widget, Object, Object[]), internalRefresh(Widget, Object, boolean, boolean), and internalRemove(Object[])? Should their experimental description also be removed while we're at it?
Comment 3 Remy Suen CLA 2008-07-31 18:59:41 EDT 
Can we get a target milestone set on this so it's not forgotten?
Comment 4 Boris Bokowski CLA 2008-10-26 10:55:26 EDT 
Marked getChildren(Widget, Object[]) as deprecated.

About the methods mentioned in comment #2, we should discuss that as part of bug 232268.
Comment 5 Boris Bokowski CLA 2008-10-28 16:49:45 EDT 
Verified by code inspection using I20081028-0100