Bug 233970 - StandardCredentialsProvider ignores ICredentialsValidator message
Summary: StandardCredentialsProvider ignores ICredentialsValidator message
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: David Dykstal CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-05-26 11:39 EDT by Don Yantzi CLA
Modified: 2008-08-25 12:13 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch for both issues. (2.10 KB, patch)
2008-05-26 11:40 EDT, Don Yantzi CLA 		ddykstal.eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Yantzi CLA 2008-05-26 11:39:19 EDT 
The StandardCredentialsProvider.acquireCredentials uses the message returned from the ICredentialsValidator to determine if there is a signon problem, but doesn't display the message to the user. Instead it displays a generic message.

It would be better if it displayed the message returned by the credentials validator since this is likely more meaningful than the generic message:

The method should also prompt the user for the user ID and password if the previous values failed validation.

I've attached a path for both issues.

Thanks.
Comment 1 Don Yantzi CLA 2008-05-26 11:40:08 EDT 
Created attachment 101994 [details]
Proposed patch for both issues.
Comment 2 David Dykstal CLA 2008-05-29 18:04:20 EDT 
Don -- you need to add a comment that states you are allowed to contribute to open source and that the patch is authored solely by you. See bug 234274 for an example or talk to Rupen.
Comment 3 Don Yantzi CLA 2008-05-30 07:58:48 EDT 
I, Don Yantzi, declare that I developed attached code from scratch,
without referencing any 3rd party materials except material licensed under the
EPL. I am authorized by my employer to make this contribution under the EPL.
Comment 4 David Dykstal CLA 2008-06-03 13:58:15 EDT 
Moving to 3.0.1, since we are out of room for RC3. Only major issues from now on.
Comment 5 David Dykstal CLA 2008-08-25 10:19:20 EDT 
Applied and tested Don's patch. This was the original intent of the ICredentialsValidator interface so it makes sense to apply now.
Comment 6 Martin Oberhuber CLA 2008-08-25 11:42:40 EDT 
Dave please add an "iplog+" flag on the Patch you applied.