Community
Participate
Working Groups
From bug 226550: For the new "Launch Shell" and "Launch Terminal" actions, I have two requets: (1) The new actions appear way down in the context menu of files displayed in the RSE view. They should appear one separator higher up in the menu. I'd think that the org.eclipse.ui.menus extension somehow allows for choosing menu placement. (2) Choosing Window > Preferences > General > Keys, the Category for the new Commands is "Launch Shell" and "Terminal Commands" respectively, which is not what I'd expect. Category should better be "Remote" or "Remote Commands" or "RSE" for both.
Created attachment 102274 [details] Screenshot of old context menu
Created attachment 102275 [details] Screenshot of new context menu Actually, the placement is not so different... it's the same menu group, just "before" the user actions & compile commands entries.
Created attachment 102633 [details] patch that fixes issue #2 I, Anna Dushistova, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
(In reply to comment #2) > Actually, the placement is not so different... it's the same menu group, just > "before" the user actions & compile commands entries. I'm not quite sure I can control the placement to that extent--I guess it depends on plugin loading order. Maybe it would be better to create separate group for the commands?
Hm, you have chosen to put the commands "Launch Shell" and "Launch Terminal" into Category "RSE". This category is what users see in the Preferences > General > Keys page as Category. I like your decision, and I think that "RSE" is a good category name. Problem with it is, that it's in the .properties file to be translated, and the deadline for adding such translatable Strings has passed already. So I see three options here: (a) Try to get special permission for new PII "RSE" to rse.ui/plugin.properties (b) Re-use existing PII, either (b1) "Remote Systems" (%View.Category.RemoteSystems), or (b2) "Remote System Explorer" (%Creation.category.name) (c) Do not apply the patch and keep status quo I personally do not like (c) at all, and I like (a) slightly better than (b1) Xuan, DaveD what do you think?
Martin, I'm fine with "Remote Systems" too, I just looked through all the existing command categories and decided that RSE would be more consistent. (In reply to comment #5) > I like your decision, and I think that "RSE" is a good category name. Problem > with it is, that it's in the .properties file to be translated, and the > deadline for adding such translatable Strings has passed already. So I see > three options here: > > (a) Try to get special permission for new PII "RSE" to rse.ui/plugin.properties > (b) Re-use existing PII, either > (b1) "Remote Systems" (%View.Category.RemoteSystems), or
We passed the drop dead date of PII drop, and it is very hard to get any PII change in now.
Ok, for the "Command Category" I see two options: (a) untranslated String "RSE" (b) re-using translation "Remote Systems" from %View.Category.RemoteSystems DaveD, what do you think? As a reminder, this is the Category name under which the commands "Launch Shell" and "Launch Terminal" will be shown in the Window > General > Keys Preference page.
(In reply to comment #8) > Ok, for the "Command Category" I see two options: > > (a) untranslated String "RSE" > > (b) re-using translation "Remote Systems" > from %View.Category.RemoteSystems > > DaveD, what do you think? As a reminder, this is the Category name under which > the commands "Launch Shell" and "Launch Terminal" will be shown in the Window > > General > Keys Preference page. > I prefer (b). I do not like translating acronyms and think we should avoid them where possible. They sometimes confuse translators.
Patch applied, re-using "Remote Systems" (%View.Category.RemoteSystems). This is adding API because there is now a Command Category with ID "org.eclipse.rse.ui.commands.category" which is declared in RSE.UI and which all future Commands should be using. Thanks for the excellent work and the patch.
