Bug 233427 - [find/replace] Split 'Find' button into 'Find Foward' and 'Find Backward' buttons
Summary: [find/replace] Split 'Find' button into 'Find Foward' and 'Find Backward' but...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 380257
Blocks:
  Show dependency tree
 
Reported: 2008-05-22 07:05 EDT by Tom Lenz CLA
Modified: 2016-04-11 12:23 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Lenz CLA 2008-05-22 07:05:51 EDT 
I find that search dialogs that have a find forward and a find backward button are easier/quicker to use than the one that's in eclipse now where you have to select a radio button each time you want to search in a different direction. 

With these two buttons the radio buttons forward and backward could be eliminated from the dialog.
Comment 1 Holger Klene CLA 2012-04-12 06:44:50 EDT 
Since 3.7 the search dialog will temporarily invert the search direction by issuing Shift-Enter -> http://help.eclipse.org/indigo/index.jsp?topic=%2Forg.eclipse.platform.doc.user%2FwhatsNew%2Fplatform_whatsnew.html

The problem is, you cannot be triggered by shift-mouse-click (which would be expected in a consistent interface.)

Another approach might be to allow for right-clicks to invert the direction.
Comment 2 Markus Keller CLA 2012-05-11 13:51:46 EDT 
> The problem is, you cannot be triggered by shift-mouse-click
That's right, Shift+Click doesn't "trigger" me ;-)

But Shift+Click reverses the find direction for me, as expected (on Windows 7).

What platform are you? :-)
Comment 3 Holger Klene CLA 2012-05-12 10:03:57 EDT 
This is Kubuntu 11.10 Oneiric Ocelot with KDE 4.7.4 running I20120315-1300 with 1.7.0_03-b04 Oracle Java

The shift-left-click on "Find" button definitely goes forward (or the checked direction that is), while shift+enter goes backward. It doesn't change using the other shift key or issuing the left-click via tapping the touchpad or via an external mouse.
Comment 4 Markus Keller CLA 2012-05-14 06:48:19 EDT 
Thanks Holger, that sounds like a bug in SWT on GTK then. Could you please file a bug against SWT? We just check SelectionEvent#stateMask.
Comment 5 Dani Megert CLA 2012-05-14 06:56:15 EDT 
(In reply to comment #4)
> Thanks Holger, that sounds like a bug in SWT on GTK then. Could you please file
> a bug against SWT? We just check SelectionEvent#stateMask.

This was once claimed to be fixed (see bug 65679 comment 21) but either it wasn't tested correctly or got broken again.
Comment 6 Holger Klene CLA 2012-05-17 09:46:41 EDT 
(In reply to comment #5)

- Will you reopen bug 65679 or
- shall I still create a new bug or
- can we take over this bug 23427 here?

BTW: Tested with Eclipse 4.2M7 I20120503-1800 and Oracle Java 1.7.0_04-b20
-> no effect of shift click
Comment 7 Dani Megert CLA 2012-05-21 03:06:06 EDT 
(In reply to comment #6)
> (In reply to comment #5)
> 
> - Will you reopen bug 65679 or
> - shall I still create a new bug or
> - can we take over this bug 23427 here?

Please file a new bug against Platform SWT.
Comment 8 Markus Keller CLA 2012-05-22 09:00:42 EDT 
I filed bug 380257 for comment 1 to 7.