Community
Participate
Working Groups
Created attachment 100888 [details] Screenshot I20080516-1333 The 'Specify Repository Information' (see screenshot) is not accessible: I found no way to select another repository location except by clicking with the mouse. Should have an 'Edit...' button next to 'Create Location'. (BTW: Create Location should have a mnemonic and an ellipsis). I got the dialog when I used the releng tools to check out projects from selected map files. The dialog from Import > Team Project Set looks the same and has the same problem.
(In reply to comment #0) > Created an attachment (id=100888) [details] > Screenshot > > I20080516-1333 > > The 'Specify Repository Information' (see screenshot) is not accessible: I > found no way to select another repository location except by clicking with the > mouse. It seems to be more a problem with ComboBoxCellEditor and the way it can be accessed. Any ideas how it can be improved without moving the issue to JFace/UI? > Should have an 'Edit...' button next to 'Create Location'. The "Create Location" works as "Edit" for existing/known locations. It's awkward I know. bug 205167 seems to be related too. > (BTW: Create Location should have a mnemonic and an ellipsis). Agreed, I'll create a patch in a minute. > I got the dialog when I used the releng tools to check out projects from > selected map files. The dialog from Import > Team Project Set looks the same > and has the same problem. They're one and the same.
Created attachment 103104 [details] Adding a mnemonic and an ellipsis
> It seems to be more a problem with ComboBoxCellEditor and the way it can be > accessed. Any ideas how it can be improved without moving the issue to > JFace/UI? If you want to have ComboBoxCellEditor accessible, then JFace and ui.workbench need to implement this, e.g. using the File > Rename command (F2) to start/stop editing a cell. I haven't followed the most recent developments in JFace in that area - maybe something like this is already there. > > Should have an 'Edit...' button next to 'Create Location'. > > The "Create Location" works as "Edit" for existing/known locations. I actually meant something like the "Set Action..." buttons in the Pull Up / Push Down refactoring dialogs. They open another dialog for the selected entry, with just a label and a Combo (which is accessible).
Created attachment 103925 [details] F2 activates the cell editor for alternate repositories (In reply to comment #3) > If you want to have ComboBoxCellEditor accessible, then JFace and ui.workbench > need to implement this, e.g. using the File > Rename command (F2) to start/stop > editing a cell. I haven't followed the most recent developments in JFace in that > area - maybe something like this is already there. You're right, it's there (bug 151295). Here is a patch that utilise some of the API. Is indivual selection of cells ok with you? Or should I stay with selecting a whole row and at the same time, when F2 gets pressed activate the editor only for the second column.
Created attachment 103926 [details] mylyn/context/zip
(In reply to comment #3) > > > Should have an 'Edit...' button next to 'Create Location'. > > > > The "Create Location" works as "Edit" for existing/known locations. > > I actually meant something like the "Set Action..." buttons in the Pull Up / > Push Down refactoring dialogs. They open another dialog for the selected entry, > with just a label and a Combo (which is accessible). Oh, now I see what you meant. If the patch above is not a solution to the issue in your opinion, I'm fine with adding such a button. Or maybe we should keep them both? The Edit button and the activation editor on F2.
Created attachment 129057 [details] Patch v03 Both patches updated.
The latest patch released to HEAD, available in builds >N20090316-2000. Markus feel free to open a new bug if you think the dialog is still missing something.
