Bug 232579 - [Help][Search] Help/Search does not always set focus to search type in area
Summary: [Help][Search] Help/Search does not always set focus to search type in area
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, polish
Depends on:
Blocks:
 
Reported: 2008-05-16 15:22 EDT by Chris Goldthorpe CLA
Modified: 2008-07-14 15:36 EDT (History)
0 users

See Also:

Attachments
Patch (2.12 KB, patch)
2008-07-14 15:34 EDT, Chris Goldthorpe CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2008-05-16 15:22:55 EDT 
I20080515-2000

Select the menu item Help/Search

The help view is shown with the search tab visible as expected but the type in area for the search area does not have focus. This is a regression since Eclipse 3.3.
Comment 1 Chris Goldthorpe CLA 2008-05-16 15:24:15 EDT 
This should be fixed for RC2.
Comment 2 Chris Goldthorpe CLA 2008-05-19 18:25:39 EDT 
After further investigation this is not a regression. There are some scenarios where the typein does not get focus but these are the same in Eclipse 3.4 as in Eclipse 3.3.

Here's one scenario which often fails 
Help/Search (focus is set correctly)
Enter "platform" in the typein and hit GO
Click on the All topics to hide the search tab
Help/Search

Expected Result: focus is on the search typein.
Actual result: most times I tried this the focus was not on the search typein.

This still should be fixed in the future but not for RC2.
Comment 3 Chris Goldthorpe CLA 2008-07-14 15:34:55 EDT 
Created attachment 107368 [details]
Patch
Comment 4 Chris Goldthorpe CLA 2008-07-14 15:36:44 EDT 
Fixed in HEAD. The help part was trying to remember which control in each tab had focus but it would often remember the wrong control. Letting each tab handle it's own focus behavior works better.