Bug 230949 - Possibly Incorrect strings not identified in the UI
Summary: Possibly Incorrect strings not identified in the UI
Status: RESOLVED FIXED
Alias: None
Product: Babel
Classification: Technology
Component: Server (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Denis Roy CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 254964 255798
  Show dependency tree
 
Reported: 2008-05-07 13:48 EDT by Denis Roy CLA
Modified: 2008-11-19 13:29 EST (History)
3 users (show)

See Also:


Attachments
Screenshot (64.61 KB, image/png)
2008-05-07 14:10 EDT, Denis Roy CLA
no flags Details
Patch v1 (14.45 KB, patch)
2008-11-19 13:19 EST, Denis Roy CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Roy CLA 2008-05-07 13:48:23 EDT
When English strings are read from CVS, those with active translations that have changed automagically flag the corresponding translations as possibly_incorrect.

The web UI should highlight files that contain possibly_incorrect translations, and perhaps put them at the top of the list of files, for rapid review

Furthermore, the translations that are possibly_incorrect should be identified as such on the UI.

select count(1) from translations where possibly_incorrect = 1 and is_active;
+----------+
| count(1) |
+----------+
|     5343 |
+----------+
Comment 1 Denis Roy CLA 2008-05-07 14:10:40 EDT
Created attachment 99134 [details]
Screenshot

Here's the idea -- highlight the files that contain potentially incorrect strings, and bring them to the top

Then, when one picks the file, highlight the strings that need attention.
Comment 2 Gabe O'Brien CLA 2008-05-07 14:21:15 EDT
This is a great idea and needs to be added as soon as possible to help translators know what needs attention.

We might also want to add a RSS feed for these changes (among others).  
Comment 3 Denis Roy CLA 2008-05-07 14:34:37 EDT
Increasing priority.  Let's make this happen sooner than later.
Comment 4 Gabe O'Brien CLA 2008-05-09 12:26:11 EDT
I was thinking this might be a good first bug for Kit to work on?  He has been gearing up to squash some bugs for Babel.  This would be a good first bug to dive into since it is mostly a UI tweak.  But it is up to Kit

Comment 5 Kit Lo CLA 2008-05-09 14:57:16 EDT
Okay, I will try. But, just be patient with me :-)
Comment 6 Denis Roy CLA 2008-10-20 13:56:25 EDT
cc'ing Antoine as he asked about this during the call.

As of today:
select count(1) from translations where is_active and possibly_incorrect ;
+----------+
| count(1) |
+----------+
|    10114 |
+----------+
Comment 7 Antoine Toulmé CLA 2008-10-20 14:40:08 EDT
How would you put back a translation as correct ? Would you have to resubmit the translation, or just uncheck a checkbox ?
Comment 8 Denis Roy CLA 2008-10-20 14:50:42 EDT
I'd say both options are needed.  If only a space or comma has changed, then the translator simply needs to remove the possibly_incorrect flag.

Comment 9 Denis Roy CLA 2008-11-19 09:26:03 EST
Marking this as blocking the Adobe contribution.  I'd also like to see the Recent Translations have a filter for the fuzzies.

Reassigning to myself as I'll get this done today.
Comment 10 Denis Roy CLA 2008-11-19 13:19:25 EST
Created attachment 118294 [details]
Patch v1

Here's a complete patch.  It identifies fuzzy strings in the UI with a bang (!) image.  I've tested it to be completely functional on my dev box, so I'll commit it to staging.
Comment 11 Denis Roy CLA 2008-11-19 13:29:23 EST
Works great on staging. Closing as fixed, this will be live soon.