Bug 230603 - UI-related language service API's should define dispose() method
Summary: UI-related language service API's should define dispose() method
Status: ASSIGNED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: IMP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 minor (vote)
Target Milestone: ---   Edit
Assignee: Robert M. Fuhrer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-06 18:37 EDT by Robert M. Fuhrer CLA
Modified: 2014-01-09 15:03 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert M. Fuhrer CLA 2008-05-06 18:37:49 EDT 
Language service API's that define UI services (such as the token colorer)
should define a dispose() method so that any O.S. resources that were allocated
(e.g. colors, fonts and such) can be properly released.
Comment 1 Stan Sutton CLA 2008-05-06 18:37:52 EDT 
Two aspects:
1)  Need dispose method in relevant SAFARI APIs, e.g., ITokenColorer, 
2)  Need to implement appropriately in templates and base classes
Comment 2 Robert M. Fuhrer CLA 2008-05-06 18:37:56 EDT 
[...gratuitous comment required by state change to ASSIGNED...]
Comment 3 Robert M. Fuhrer CLA 2008-05-08 16:19:30 EDT 
<gratuitous comment for change of status>
Comment 4 Robert M. Fuhrer CLA 2009-06-26 17:02:58 EDT 
Candidate UI-related interfaces for addition of a dispose() API call:

 - IEditorService - could theoretically do anything, so perhaps should add dispose() just to be safe
 - IEntityImageDecorator
 - ILabelProvider
 - IOutliner
 - ITokenColorer

Some of these have a base class in the org.eclipse.imp.services.base, for those, we can introduce the new method without breaking existing client code. The rest would involve a breaking API change, so we'll need to get some user input on those.