Bug 2296 - AddBookmarkAction should use IAdaptable to retrieve the resource (1GEN8B7)
Summary: AddBookmarkAction should use IAdaptable to retrieve the resource (1GEN8B7)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P1 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Knut Radloff CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:33 EDT by Dirk Baeumer CLA
Modified: 2002-01-17 15:43 EST (History)
0 users

See Also:

Attachments
Proposed fix for org.eclipse.ui.actions.AddBookmarkAction.java (1.45 KB, patch)
2002-01-16 17:14 EST, Knut Radloff CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2001-10-10 22:33:29 EDT 
As all other actions AddBookmarkAction should use IAdaptable to retrieve the IFile from the selection so that it can be reused in
	other navigators like packages view too.


NOTES:
Comment 1 DJ Houghton CLA 2001-10-29 18:05:51 EST 
PRODUCT VERSION:
	116
Comment 2 Knut Radloff CLA 2002-01-16 17:14:52 EST 
Created attachment 229 [details]
Proposed fix for org.eclipse.ui.actions.AddBookmarkAction.java
Comment 3 Knut Radloff CLA 2002-01-16 17:19:37 EST 
Verified that the fixed AddBookmarkAction (see attachment) can be used by JDT 
PackageExplorerPart in place of their own. Tested in Navigator and Packages 
views.
Sent mail to Simon asking for review.
Comment 4 Simon Arsenault CLA 2002-01-17 15:43:50 EST 
Accepted proposed patch with one minor change - added an initial test for IFile 
so as to avoid going thru the costly getAdapter call if we already have an 
IFile.

Fix will be in build > 2002-01-17